Skip to content

Add support for custom_properties#42

Merged
pavlovic-ivan merged 4 commits intomainfrom
add-support-for-custom-properties
Mar 26, 2026
Merged

Add support for custom_properties#42
pavlovic-ivan merged 4 commits intomainfrom
add-support-for-custom-properties

Conversation

@pavlovic-ivan
Copy link
Copy Markdown
Contributor

@pavlovic-ivan pavlovic-ivan commented Mar 24, 2026

Requested by @tabathad . In this PR i've added support for custom_properties. Basically, any key-value pair can be added in that object, however terraform will fail if non-existing custom property is set. It supports oss_lifecycle with values from the ticket. I've configured the property from org settings so we can support it. Do note that i've renamed the property from oss-lifecycle to oss_lifecycle - snake case used throughout the yaml configuration.

Because of this implementation, i've added our custom GR-OSS json schema for validation, because we will use this property, others probably will not.

Roll out involves adding Custom Properties read&write scope to the Github App. Per org

@jgiannuzzi
Copy link
Copy Markdown
Member

I like the idea of having a custom schema that extends the generic one. However I would keep it (and its documentation) out of this repo and into the specific config repo for the corresponding org.

@pavlovic-ivan
Copy link
Copy Markdown
Contributor Author

@jgiannuzzi I don't like separating documentation from the code. So i suggest documenting custom properties from a high-level, implementation level, here, and move the custom schema to our gr-oss repos. Sounds good? Is that a good compromise?

@jgiannuzzi
Copy link
Copy Markdown
Member

Yes obviously they should be documented here, maybe even along a template of how to customise the schema. It's just the GR-OSS specific fields that I think don't belong to this repo (their schema and their docs)

@pavlovic-ivan
Copy link
Copy Markdown
Contributor Author

@jgiannuzzi comments addressed

Copy link
Copy Markdown
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think having some information on how to customise the schema would be useful, but that can be in a follow-up PR

@pavlovic-ivan pavlovic-ivan merged commit 19ecfef into main Mar 26, 2026
1 check passed
@pavlovic-ivan pavlovic-ivan deleted the add-support-for-custom-properties branch March 26, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants