Open
Conversation
tmct
reviewed
Mar 31, 2026
pyproject.toml
Outdated
| "opentelemetry-exporter-otlp-proto-grpc", | ||
| "opentelemetry-exporter-otlp-proto-http", | ||
| "opentelemetry-proto", | ||
| "opentelemetry-sdk", |
Member
There was a problem hiding this comment.
Would definitely like to see a lower bound on at least this one please - hopefully not bleeding edge but whatever suffices for everything we use
Contributor
Author
There was a problem hiding this comment.
on the second thought, let's be safe and go with 1.39 everywhere. it's lower bound in the end.
tmct
approved these changes
Apr 1, 2026
| "opentelemetry-exporter-otlp-proto-grpc>=1.39.0", | ||
| "opentelemetry-exporter-otlp-proto-http>=1.39.0", | ||
| "opentelemetry-proto>=1.39.0", | ||
| "opentelemetry-sdk>=1.39.0", |
Member
There was a problem hiding this comment.
Thanks. This implies a number of the other deps and bounds so I'd only tend to declare the ones we consume directly - but this is looking good now, no need to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
OTel world introduced breaking changes in the latest version.
Todo (in separate PR):