Fallback storage multithread read#175
Draft
EnricoMi wants to merge 6 commits intofallback-storage-lazy-readfrom
Draft
Fallback storage multithread read#175EnricoMi wants to merge 6 commits intofallback-storage-lazy-readfrom
EnricoMi wants to merge 6 commits intofallback-storage-lazy-readfrom
Conversation
|
EnricoMi
force-pushed
the
fallback-storage-multithread-read
branch
from
bf4226c to
61e5471
Compare
EnricoMi
force-pushed
the
fallback-storage-multithread-read
branch
from
cadda9c to
31e2cff
Compare
EnricoMi
force-pushed
the
fallback-storage-lazy-read
branch
from
924790d to
2952c86
Compare
EnricoMi
force-pushed
the
fallback-storage-multithread-read
branch
from
31e2cff to
21de7b8
Compare
EnricoMi
force-pushed
the
fallback-storage-lazy-read
branch
from
2952c86 to
ff9e3b3
Compare
Removes "Fast fail when failed to get fallback storage blocks" as fallback storage blocks are fetched concurrently and fast fail is not guaranteed any more.
This blocks cleanup() calling fallbackStorageReadPool.shutdownNow() while futures are locking results to put FailureFetchResults. Otherwise, that put in catch clauses would be interrupted and that exception kills the executor. Logging errors only if !isZombie, meaning the iterator is not yet cleaning up. Further, FailureFetchResult are putFirst to stop iteration as quickly as possible. Finally, fallbackStorageReadPool.shutdownNow() is only called in cleanup().
EnricoMi
force-pushed
the
fallback-storage-multithread-read
branch
from
833e9de to
6ed4e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?