Fix incorrect RIP-relative detection logic and mmap() parameter order#109
Merged
GJDuck merged 2 commits intoGJDuck:masterfrom Mar 3, 2026
Merged
Fix incorrect RIP-relative detection logic and mmap() parameter order#109GJDuck merged 2 commits intoGJDuck:masterfrom
mmap() parameter order#109GJDuck merged 2 commits intoGJDuck:masterfrom
Conversation
Owner
|
Thanks! The mmap() still worked since those macros happen to have the same value. I am not sure why the RIP-relative detection did not cause problems though. |
Contributor
Author
|
Thank you for merging my patches. I’m glad I could contribute to your project :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d03f658: The code is checking for RIP-relative addressing (mod==0x00 AND rm==0x05). The original condition (mod != 0x00 && rm != 0x05) incorrectly applied De Morgan's law, causing false positives.
Correct De Morgan's:
!(A && B) = !A || !BChanged to:
(mod != 0x00 || rm != 0x05)8cdd39d: The 3rd and 4th arguments to mmap() were in wrong order. POSIX signature:
mmap(addr, length, prot, flags, fd, offset)