fix: reset editor scroll state on tab changes

[Gabko14]

Summary

• reset the reused AppKit editor scroll view after programmatic text swaps so a visible scrollbar does not linger into a fresh tab
• keep the fix at the editor configuration layer instead of adding another SwiftUI tab-switch workaround
• add a regression test for reused scroll-view reset behavior

Testing

• xcodebuild test -project Ghostly.xcodeproj -scheme Ghostly -destination 'platform=macOS' -only-testing:GhostlyTests CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO

[claude]

Review: Approved

Clean, focused fix that addresses the scrollbar lingering issue at the right layer.

What is good:

• Correct approach: Fixing this in EditorTextViewConfiguration.updateText keeps scroll behavior coupled with text updates, rather than scattering workarounds across tab-switching logic
• Belt-and-suspenders reset: Using both scrollRangeToVisible and contentView.scroll(to: .zero) plus reflectScrolledClipView ensures reliable reset across AppKit edge cases
• Solid test: The regression test properly simulates the scenario (scroll to bottom, update text, verify reset)

Minor observations (no action required):

1. Unconditional reset: Every updateText call now resets scroll position. This is fine because:

   • User keystrokes do not go through this method (NSTextView handles native editing)
   • The early return guard (textView.string != text) skips no-op updates
   • Resetting to top on tab switch is reasonable UX

2. Force-unwrap in test (textView.textContainer!): Safe here since makeScrollView always creates a valid text container, but could use optional binding for consistency with the surrounding code style.

Good work keeping the fix minimal and testable.

[claude]

Review: Changes Requested

Critical Issue: Unrelated changes bundled in PR

This PR claims to "reset editor scroll state on tab changes" but bundles 19 unrelated files alongside the 2 files that actually implement the fix. The majority of changes are beads issue tracking infrastructure that have nothing to do with the scrollbar fix:

Files that belong in this PR (2):

• Ghostly/Utilities/EditorTextViewConfiguration.swift - the actual fix
• GhostlyTests/EditorTextViewConfigurationTests.swift - the test

Files that should NOT be in this PR (20):

• .beads/ directory changes (README, metadata, hooks, backup files)
• .beads/dolt-monitor.pid, .beads/dolt-server.activity, .beads/dolt-server.port - runtime files with machine-specific data (PIDs, ports, timestamps) that should NEVER be committed
• .gitignore changes
• AGENTS.md additions

Why this matters:

1. PRs should be atomic - one logical change per PR makes review easier and rollbacks cleaner
2. Runtime files committed - .beads/dolt-monitor.pid (contains 79528), .beads/dolt-server.port (contains 14049), .beads/dolt-server.activity (timestamp) are machine-specific and will conflict/be stale on other machines
3. Review confusion - the existing approval review completely missed these unrelated files

The actual code fix looks good

The resetScrollState implementation is correct:

@MainActor
private static func resetScrollState(for textView: NSTextView) {
    guard let scrollView = textView.enclosingScrollView else { return }
    textView.scrollRangeToVisible(NSRange(location: 0, length: 0))
    scrollView.contentView.scroll(to: .zero)
    scrollView.reflectScrolledClipView(scrollView.contentView)
}

The test is also reasonable, though the final assertion is outside the if let block which could technically pass vacuously if textView were nil (though it won't be in practice).

Recommended action:

1. Remove all .beads/ changes from this PR (especially the runtime files)
2. Remove AGENTS.md and .gitignore changes
3. Create a separate PR for beads integration if that's desired
4. Add .beads/dolt-monitor.pid, .beads/dolt-server.activity, .beads/dolt-server.port to .gitignore - these should never be tracked

Once the unrelated files are removed, this PR can be approved.

[claude]

Review

Major Issue: Unrelated changes bundled

This PR bundles two completely unrelated changes:

1. The actual scrollbar fix (good) - EditorTextViewConfiguration.swift and its test
2. Beads issue tracking initialization (unrelated) - all the .beads/ files, AGENTS.md updates, .gitignore changes

These should be separate PRs. The beads setup is a significant addition to the repo that deserves its own review and commit history.

Runtime files committed

The following files should NOT be committed as they are runtime/ephemeral:

• .beads/dolt-monitor.pid - process ID (machine-specific)
• .beads/dolt-server.activity - timestamp
• .beads/dolt-server.port - port number (machine-specific)
• .beads/backup/backup_state.json - contains timestamps specific to when backup ran

These will cause merge conflicts and contain stale data. They should be in .beads/.gitignore.

---

The scrollbar fix itself

The core fix is sound:

@MainActor
private static func resetScrollState(for textView: NSTextView) {
    guard let scrollView = textView.enclosingScrollView else { return }

    textView.scrollRangeToVisible(NSRange(location: 0, length: 0))
    scrollView.contentView.scroll(to: .zero)
    scrollView.reflectScrolledClipView(scrollView.contentView)
}

• Correctly placed at the configuration layer
• Called when text content changes (appropriate trigger)
• Test covers the regression scenario

Minor note on test (line 76):

textView.layoutManager?.ensureLayout(for: textView.textContainer!)

Force-unwrap of textContainer could be avoided with optional chaining since the test is already inside if let textView.

---

Recommendation

1. Remove all .beads/ changes and beads-related updates from this PR
2. Remove the runtime files from the commit
3. Create a separate PR for beads initialization if desired

The scrollbar fix alone is approvable once the unrelated changes are removed.