feat: Add CD001-MCP FinMail Repository and Routing (CD001, #27)#312
Open
steadhac wants to merge 2 commits into
Open
feat: Add CD001-MCP FinMail Repository and Routing (CD001, #27)#312steadhac wants to merge 2 commits into
steadhac wants to merge 2 commits into
Conversation
198dd9f to
ce17661
Compare
8d5b762 to
2d40ef7
Compare
…ting Coverage Tests (FM-REPO, FM-RTE)
9532a2b to
2d801c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #312 — FinMail Repository and Routing
Add full unit test coverage for the FinMail repository layer and address routing module.
Tests exercise all repository query methods — vendor email filters, admin email filters,
external emails, stats, unread counts, bulk mark-as-read, pagination, cross-vendor
isolation, and Email model methods — plus the routing function that resolves addresses
to inboxes.
No bugs expected in the repository/routing layer — all tests currently pass.
Tests follow the established pattern with:
📁 Test Files
tests/unit/mcp/test_finmail_repositories.py
tests/unit/mcp/test_finmail_routing.py
TestListVendorEmailsFilters
TestGetVendorEmailStats
TestGetVendorUnreadCount
TestMarkAllVendorAsRead
TestListAdminEmailsFilters
TestGetAdminEmailStats
TestMarkAllAdminAsRead
TestExternalEmails
TestMarkAsRead
TestListAdminEmailsIsReadTrue
TestPagination
TestCrossVendorIsolation
TestEmailModel
TestGetDepartmentAddresses
TestRouteAndDeliverUserBranch