Skip to content

fix(findrive): enforce 255 char limit on filename to prevent DoS (fix… #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deveshreddyp wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(findrive): enforce 255 char limit on filename to prevent DoS (fix… #384

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
256f40e
fix(findrive): enforce 255 char limit on filename to prevent DoS (fix…
deveshreddyp Mar 27, 2026
5be0918
refactor(findrive): remove unnecessary indirection per maintainer review
deveshreddyp Mar 27, 2026
5fbb726
chore(findrive): remove redundant test suite in favor of PR #317
deveshreddyp Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions finbot/mcp/servers/findrive/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,20 @@ def upload_file(
retrieval. Use this for storing invoice PDFs, receipts, and supporting
documentation.
"""
max_size = config.get("max_file_size_kb", 500) * 1024
conf = config or DEFAULT_CONFIG
MAX_FILENAME_LENGTH = 255
if len(filename) > MAX_FILENAME_LENGTH:
return {"error": f"filename exceeds maximum length of {MAX_FILENAME_LENGTH} characters"}

max_size = conf.get("max_file_size_kb", 500) * 1024
if len(content.encode("utf-8")) > max_size:
return {"error": f"File exceeds maximum size of {config.get('max_file_size_kb', 500)}KB"}
return {"error": f"File exceeds maximum size of {conf.get('max_file_size_kb', 500)}KB"}

with db_session() as db:
repo = FinDriveFileRepository(db, session_context)

vid = vendor_id if vendor_id > 0 else None
if _is_vendor_session(session_context) and vid is None:
if session_context and _is_vendor_session(session_context) and vid is None:
vid = session_context.current_vendor_id

f = repo.create_file(
Expand Down