Add runtime type check

[luizakp]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
generalmagic	✅ Ready (Inspect)	Visit Preview	Nov 25, 2022 at 1:50PM (UTC)

[marthendalnunes]

Overall the changes are good, just check the proper error message handling and the optional helper function to keep your code cleaner :D

[marthendalnunes]

To keep it DRY, I recommend creating a helper function that takes the optional data variable and its message and returns an empty string, and replaces all of these ternary operators.

something like that

// Helper function that returns an empty string if the optional data is falsy
    const handleOptionalData = (optionalData: string, message: string) => optionalData ? message : ''

// instead of 
const discordHandle = discord ? `Discord handle: ${discord}` : ''

// replacing for
const discordHandle = handleOptionalData(discord, `Discord handle: ${discord}`)

[marthendalnunes]

In case of an error in the execution of the endpoint is always good to also send the error message. Getting the message with the correct typing from an error response is a bit tricky, but here's a solution:

Suggested change

	} catch (err) {
	console.log(err)
	res.status(400).json({
	success: false,
	})
	}
	} catch (err) {
	console.log(err)
	let message
	if (err instanceof Error) message = err.message
	else message = String(err)
	res.status(400).json({
	success: false,
	message
	})
	}

[marthendalnunes]

Zod string objects has a built-in method for checking the email syntax:

Suggested change

	email: nonEmptyStringContraint,
	email: nonEmptyStringContraint.email(),