Skip to content

bugfix(gui): Prevent use-after-free crashes in WOLWelcomeMenu during shutdown #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 1 commit into from
May 7, 2026
+6 −0
Merged

bugfix(gui): Prevent use-after-free crashes in WOLWelcomeMenu during shutdown #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLWelcomeMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,12 @@ WindowMsgHandledType WOLWelcomeMenuSystem( GameWindow *window, UnsignedInt msg,
{
UnicodeString txtInput;

// During shutdown the window hierarchy is being torn down; ignore all
// messages to prevent use-after-free crashes caused by mouse-enter/leave
// events that are still in-flight while the parent window is being destroyed.
if( isShuttingDown )
return MSG_IGNORED;

switch( msg )
{

Expand Down
Loading