Skip to content

feat(generals_online): Exclude local disconnect stats retrieval in online builds#489

Merged
x64-dev merged 1 commit intomainfrom
seer/feat/online-disconnect-stats-exclusion
May 7, 2026
Merged

feat(generals_online): Exclude local disconnect stats retrieval in online builds#489
x64-dev merged 1 commit intomainfrom
seer/feat/online-disconnect-stats-exclusion

Conversation

@seer-by-sentry
Copy link
Copy Markdown

@seer-by-sentry seer-by-sentry Bot commented May 7, 2026

Fixes CLIENT-19R. The issue was that: GameSpyLoadScreen::init accesses uninitialized PSPlayerStats data when NGMP_OnlineServices_StatsInterface is null, causing a null pointer dereference.

  • The declaration of GetAdditionalDisconnectsFromUserFile is now conditionally compiled, excluding it when GENERALS_ONLINE is defined.
  • The call to GetAdditionalDisconnectsFromUserFile for calculating player disconnects is now conditionally compiled, excluding it when GENERALS_ONLINE is defined.

This fix was generated by Seer in Sentry, triggered by x64-dev. 👁️ Run ID: 13978072

Not quite right? Click here to continue debugging with Seer.

@seer-by-sentry seer-by-sentry Bot requested a review from x64-dev May 7, 2026 21:17
@x64-dev x64-dev marked this pull request as ready for review May 7, 2026 21:18
@x64-dev x64-dev merged commit 3d3ddc9 into main May 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant