Skip to content

bugfix(system): Prevent buffer overflows and uninitialized memory in stack dump and exception handling #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 1 commit into from
May 7, 2026
+6 −6
Merged

bugfix(system): Prevent buffer overflows and uninitialized memory in stack dump and exception handling #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core/Libraries/Source/WWVegas/WWLib/Except.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ void Dump_Exception_Info(EXCEPTION_POINTERS *e_info)
/*
** Scrap buffer for constructing dump strings
*/
char scrap [256];
char scrap [256] = {};

/*
** Clear out the dump buffer
Expand Down Expand Up @@ -660,7 +660,7 @@ void Dump_Exception_Info(EXCEPTION_POINTERS *e_info)
** Dump the bytes at EIP. This will make it easier to match the crash address with later versions of the game.
*/
DebugString("EIP bytes dump...\n");
sprintf(scrap, "\r\nBytes at CS:EIP (%08X) : ", context->Eip);
snprintf(scrap, ARRAY_SIZE(scrap), "\r\nBytes at CS:EIP (%08X) : ", context->Eip);

unsigned char *eip_ptr = (unsigned char *) (context->Eip);
char bytestr[32];
Expand Down
4 changes: 2 additions & 2 deletions Generals/Code/GameEngine/Source/Common/System/StackDump.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ void DumpExceptionInfo( unsigned int u, EXCEPTION_POINTERS* e_info )
/*
** Dump the bytes at EIP. This will make it easier to match the crash address with later versions of the game.
*/
char scrap[512];
char scrap[512] = {};
DOUBLE_DEBUG ( ("EIP bytes dump..."));
wsprintf (scrap, "\nBytes at CS:EIP (%08X) : ", context->Eip);

Expand All @@ -619,7 +619,7 @@ void DumpExceptionInfo( unsigned int u, EXCEPTION_POINTERS* e_info )
{
if (IsBadReadPtr(eip_ptr, 1))
{
lstrcat (scrap, "?? ");
strlcat(scrap, "?? ", ARRAY_SIZE(scrap));
}
else
{
Expand Down
4 changes: 2 additions & 2 deletions GeneralsMD/Code/GameEngine/Source/Common/System/StackDump.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ void DumpExceptionInfo( unsigned int u, EXCEPTION_POINTERS* e_info )
/*
** Dump the bytes at EIP. This will make it easier to match the crash address with later versions of the game.
*/
char scrap[512];
char scrap[512] = {};
DOUBLE_DEBUG ( ("EIP bytes dump..."));
wsprintf (scrap, "\nBytes at CS:EIP (%08X) : ", context->Eip);

Expand All @@ -619,7 +619,7 @@ void DumpExceptionInfo( unsigned int u, EXCEPTION_POINTERS* e_info )
{
if (IsBadReadPtr(eip_ptr, 1))
{
lstrcat (scrap, "?? ");
strlcat(scrap, "?? ", ARRAY_SIZE(scrap));
}
else
{
Expand Down
Loading