Skip to content

bugfix(network): Prevent out-of-bounds access and improve fallback for packet router slots#496

Merged
x64-dev merged 1 commit intomainfrom
seer/bugfix/network-router-bounds-check
May 7, 2026
Merged

bugfix(network): Prevent out-of-bounds access and improve fallback for packet router slots#496
x64-dev merged 1 commit intomainfrom
seer/bugfix/network-router-bounds-check

Conversation

@seer-by-sentry
Copy link
Copy Markdown

@seer-by-sentry seer-by-sentry Bot commented May 7, 2026

Fixes CLIENT-1AW. The issue was that: DisconnectManager accesses deallocated ConnectionManager data after player disconnection, causing a write access violation.

  • Corrected loop bounds for iterating through m_packetRouterFallback array in disconnectPlayer and getNextPacketRouterSlot.
  • Added explicit bounds checking before accessing m_packetRouterFallback to prevent potential out-of-bounds reads.
  • Ensured m_packetRouterSlot defaults to m_localSlot if no valid fallback is found during player disconnection.
  • Modified getNextPacketRouterSlot to return MAX_SLOTS when no subsequent packet router is available, indicating an invalid slot.

This fix was generated by Seer in Sentry, triggered by x64-dev. 👁️ Run ID: 13978503

Not quite right? Click here to continue debugging with Seer.

@seer-by-sentry seer-by-sentry Bot requested a review from x64-dev May 7, 2026 21:28
@x64-dev x64-dev marked this pull request as ready for review May 7, 2026 21:29
@x64-dev x64-dev merged commit 809242d into main May 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant