feat!: replace GNS logo with ESI logo #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses PNG instead of SVG (big L), so consumer must set up a handler for the embedded asset
bpeng
reviewed
Jul 1, 2025
ui/geonet_footer/footer.go
Outdated
|
|
||
| // ReturnFooterAssetPattern returns the path pattern for the footer asset server. | ||
| func ReturnFooterAssetPattern() string { | ||
| return "/images/footer_pngs/" |
Contributor
There was a problem hiding this comment.
directory can be a const and shared
Make asset dir const
bpeng
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses PNG instead of SVG, so consumer must set up a handler for the embedded asset. Also more CSS must be set.
Proposed Changes
Changes proposed in this pull request:
Production Changes
The following production changes are required to deploy these changes:
Review
Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.
Code Review Guide
Insert check list here if needed.