Skip to content

Conversation

@junghao
Copy link
Contributor

@junghao junghao commented Sep 18, 2025

Proposed Changes

Changes proposed in this pull request:

  • Expose weft.InitAssets() so the using project can override the default assets/assets directory. This is necessary for Ko based build (Ko uses kodata as asset directory and cannot be changed).

The default init() still works so no impact to any existing projects. This is just opening a window for projects which need this. For projects using Ko, run InitAssets(kodatapath+"/assets", "assets") before mux init.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

Copy link
Contributor

@bpeng bpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@sue-h-gns sue-h-gns merged commit 3862d02 into main Sep 22, 2025
8 checks passed
@sue-h-gns sue-h-gns deleted the assets-init branch September 22, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants