Skip to content

Conversation

@CallumNZ
Copy link
Contributor

@CallumNZ CallumNZ commented Nov 6, 2025

Proposed Changes

Reference: https://github.com/GeoNet/tickets/issues/19098

Changes proposed in this pull request:

  • Install geonet-bootstrap,fontawesome from s3/npm

Production Changes

The following production changes are required to deploy these changes:

  • None

I've checked the ui elements, all look the same, so no changes required.
I tried on www and was seeing some discrepancies, so I did this to help see where the clash is happening. Since it looks good here, I know it's some CSS issues downstream.

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@CallumNZ CallumNZ requested a review from bpeng November 6, 2025 21:32
@CallumNZ CallumNZ changed the title feat: install dependencies from npm feat: install dependencies from npm/s3 Nov 6, 2025
@CallumNZ CallumNZ force-pushed the uses3registryHeader branch from 67ddf1a to 3db7602 Compare December 9, 2025 20:44
Copy link
Contributor

@bpeng bpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good

@sue-h-gns sue-h-gns merged commit 93e1f03 into main Dec 9, 2025
8 checks passed
@sue-h-gns sue-h-gns deleted the uses3registryHeader branch December 9, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants