feat: Support Roundcube 1.7 static files handling#34
Open
GermanCoding wants to merge 2 commits intomasterfrom
Open
feat: Support Roundcube 1.7 static files handling#34GermanCoding wants to merge 2 commits intomasterfrom
GermanCoding wants to merge 2 commits intomasterfrom
Conversation
Roundcube 1.7 forces us to go trough static.php for security. However, this script does not exist in older Roundcube releases. To maintain backwards compatibility, figure out the correct path at runtime depending on the version.
GermanCoding
force-pushed
the
roundcube-1.7
branch
from
fff81ca to
a69b58e
Compare
Owner
Author
|
As we do not have full E2E testing, I manually gave this a spin with 1.7-RC6 (in docker), and confirmed that this works as intended. |
Open
Owner
Author
|
Note: Reading the current Roundcube code, there may be a simpler alternative: Instead of parsing the Roundcube version ourselves, we could call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roundcube 1.7 forces us to go through static.php for security. However, this script does not exist in older Roundcube releases. To maintain backwards compatibility, figure out the correct path at runtime depending on the version.
Fixes #33