Skip to content

fix(signup): align frontend password validation with backend Zod schema #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehul-m-prajapati merged 2 commits into from
May 26, 2026
Merged

fix(signup): align frontend password validation with backend Zod schema #465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a9ff43
fix(signup): align frontend password validation with backend Zod schema
anshul23102 May 23, 2026
cb066b4
Merge branch 'main' into fix/415-password-validation-mismatch
mehul-m-prajapati May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 53 additions & 98 deletions src/pages/Signup/Signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,108 +8,63 @@ import type { ThemeContextType } from "../../context/ThemeContext";

const backendUrl = import.meta.env.VITE_BACKEND_URL;

// Must mirror the Zod rule in backend/validators/authValidator.js exactly.
// Requires: lowercase, uppercase, digit, and one special character from @$!%*?&
// Minimum 8 characters, maximum enforced by the backend (100).
const PASSWORD_REGEX = /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[@$!%*?&])[A-Za-z\d@$!%*?&]{8,}$/;
const PASSWORD_ERROR =
"Password must be at least 8 characters and include uppercase, lowercase, a number, and a special character (@$!%*?&)";

interface SignUpFormData {
username: string;
email: string;
password: string;
}

interface FormErrors {
firstName?: string;
lastName?: string;
email?: string;
password?: string;
}

interface IconEyeProps {
open: boolean;
}

function IconUser(): JSX.Element {
return (
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
<circle cx="12" cy="8" r="4"/><path d="M4 20c0-4 3.6-7 8-7s8 3 8 7"/>
</svg>
);
}

function IconMail(): JSX.Element {
return (
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
<rect x="2" y="4" width="20" height="16" rx="2"/><path d="m2 7 10 7 10-7"/>
</svg>
);
}

function IconLock(): JSX.Element {
return (
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
<rect x="5" y="11" width="14" height="11" rx="2"/><path d="M8 11V7a4 4 0 0 1 8 0v4"/>
</svg>
);
}

function IconEye({ open }: IconEyeProps): JSX.Element {
return open ? (
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
<path d="M2 12s3-7 10-7 10 7 10 7-3 7-10 7-10-7-10-7z"/><circle cx="12" cy="12" r="3"/>
</svg>
) : (
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
<path d="M17.94 17.94A10.07 10.07 0 0 1 12 20c-7 0-10-7-10-7a18.45 18.45 0 0 1 5.06-5.94"/><path d="M9.9 4.24A9.12 9.12 0 0 1 12 4c7 0 10 7 10 7a18.5 18.5 0 0 1-2.16 3.19"/><line x1="1" y1="1" x2="23" y2="23"/>
</svg>
);
}

function IconArrow(): JSX.Element {
return (
<svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
<path d="M5 12h14M12 5l7 7-7 7"/>
</svg>
);
}

function IconCheck(): JSX.Element {
return (
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="#7c3aed" strokeWidth="2.5" strokeLinecap="round" strokeLinejoin="round">
<polyline points="20 6 9 17 4 12"/>
</svg>
);
}

function GoogleIcon(): JSX.Element {
return (
<svg width="16" height="16" viewBox="0 0 24 24">
<path fill="#4285F4" d="M22.56 12.25c0-.78-.07-1.53-.2-2.25H12v4.26h5.92c-.26 1.37-1.04 2.53-2.21 3.31v2.77h3.57c2.08-1.92 3.28-4.74 3.28-8.09z"/>
<path fill="#34A853" d="M12 23c2.97 0 5.46-.98 7.28-2.66l-3.57-2.77c-.98.66-2.23 1.06-3.71 1.06-2.86 0-5.29-1.93-6.16-4.53H2.18v2.84C3.99 20.53 7.7 23 12 23z"/>
<path fill="#FBBC05" d="M5.84 14.09c-.22-.66-.35-1.36-.35-2.09s.13-1.43.35-2.09V7.07H2.18C1.43 8.55 1 10.22 1 12s.43 3.45 1.18 4.93l3.66-2.84z"/>
<path fill="#EA4335" d="M12 5.38c1.62 0 3.06.56 4.21 1.64l3.15-3.15C17.45 2.09 14.97 1 12 1 7.7 1 3.99 3.47 2.18 7.07l3.66 2.84c.87-2.6 3.3-4.53 6.16-4.53z"/>
</svg>
);
}

function GitHubIcon(): JSX.Element {
return (
<svg width="16" height="16" viewBox="0 0 24 24" fill="#24292e">
<path d="M12 2C6.477 2 2 6.484 2 12.017c0 4.425 2.865 8.18 6.839 9.504.5.092.682-.217.682-.483 0-.237-.008-.868-.013-1.703-2.782.605-3.369-1.343-3.369-1.343-.454-1.158-1.11-1.466-1.11-1.466-.908-.62.069-.608.069-.608 1.003.07 1.531 1.032 1.531 1.032.892 1.53 2.341 1.088 2.91.832.092-.647.35-1.088.636-1.338-2.22-.253-4.555-1.113-4.555-4.951 0-1.093.39-1.988 1.029-2.688-.103-.253-.446-1.272.098-2.65 0 0 .84-.27 2.75 1.026A9.564 9.564 0 0 1 12 6.844a9.59 9.59 0 0 1 2.504.337c1.909-1.296 2.747-1.027 2.747-1.027.546 1.379.202 2.398.1 2.651.64.7 1.028 1.595 1.028 2.688 0 3.848-2.339 4.695-4.566 4.943.359.309.678.92.678 1.855 0 1.338-.012 2.419-.012 2.747 0 .268.18.58.688.482A10.019 10.019 0 0 0 22 12.017C22 6.484 17.522 2 12 2z"/>
</svg>
);
}

export default function RegisterPage(): JSX.Element {
const [form, setForm] = useState<FormState>({ firstName: "", lastName: "", email: "", password: "" });
const [showPass, setShowPass] = useState<boolean>(false);
const [errors, setErrors] = useState<FormErrors>({});
const [loading, setLoading] = useState<boolean>(false);
const [success, setSuccess] = useState<boolean>(false);

const validate = (): FormErrors => {
const e: FormErrors = {};
if (!form.firstName.trim()) e.firstName = "Required";
if (!form.lastName.trim()) e.lastName = "Required";
if (!form.email.match(/^[^\s@]+@[^\s@]+\.[^\s@]+$/)) e.email = "Enter a valid email";
if (form.password.length < 8) e.password = "Min 8 characters";
return e;
const SignUp: React.FC = () => {
const [formData, setFormData] = useState<SignUpFormData>({
username: "",
email: "",
password: "",
});
const [message, setMessage] = useState<string>("");
const [errors, setErrors] = useState({
username: "",
email: "",
password: "",
});
const [showPassword, setShowPassword] = useState(false);
const [isLoading, setIsLoading] = useState(false);
const navigate = useNavigate();
const themeContext = useContext(ThemeContext) as ThemeContextType;
const { mode } = themeContext;

const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
const { name, value } = e.target;
setFormData({ ...formData, [name]: value });
let errorMessage = "";
if (name === "username") {
if (!value.trim()) {
errorMessage = "Username is required";
} else if (!/^[A-Za-z\s]+$/.test(value)) {
errorMessage = "Only letters are allowed";
}
}
if (name === "email") {
if (!value.trim()) {
errorMessage = "Email is required";
} else if (!/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(value.trim())) {
errorMessage = "Enter a valid email";
}
}
if (name === "password") {
if (!value.trim()) {
errorMessage = "Password is required";
} else if (!PASSWORD_REGEX.test(value)) {
errorMessage = PASSWORD_ERROR;
}
}
setErrors((prev) => ({ ...prev, [name]: errorMessage }));
};

const handleSubmit = async (e: React.FormEvent) => {
Expand All @@ -126,8 +81,8 @@ export default function RegisterPage(): JSX.Element {
: "";
const passwordError = !formData.password.trim()
? "Password is required"
: !/^(?=.*[A-Za-z])(?=.*\d)[A-Za-z\d@$!%*#?&]{8,}$/.test(formData.password)
? "Password must be 8+ characters with letters and numbers"
: !PASSWORD_REGEX.test(formData.password)
? PASSWORD_ERROR
: "";
if (usernameError || emailError || passwordError) {
setErrors({ username: usernameError, email: emailError, password: passwordError });
Expand Down
Loading