feat: improve activity feed UX with reusable empty state component#542
feat: improve activity feed UX with reusable empty state component#542Tech4Aditya wants to merge 1 commit into
Conversation
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA new reusable ChangesEmpty State UX Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🎉 Thank you @Tech4Aditya for your contribution. Please make sure your PR follows https://github.com/GitMetricsLab/github_tracker/blob/main/CONTRIBUTING.md#-pull-request-guidelines
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/EmptyState.tsx (1)
12-12: ⚡ Quick winHide decorative icon from screen readers.
The emoji at Line 12 is decorative; mark it
aria-hidden="true"so it isn’t announced unnecessarily.Proposed fix
- <div className="text-5xl mb-3">📭</div> + <div className="text-5xl mb-3" aria-hidden="true">📭</div>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/EmptyState.tsx` at line 12, The decorative emoji in the EmptyState component (the div with className "text-5xl mb-3") should be hidden from screen readers; update that element to include aria-hidden="true" so the icon is not announced to assistive technologies.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/EmptyState.tsx`:
- Line 12: The decorative emoji in the EmptyState component (the div with
className "text-5xl mb-3") should be hidden from screen readers; update that
element to include aria-hidden="true" so the icon is not announced to assistive
technologies.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5eb184a8-18cb-487d-a9e7-6465ad33a316
📒 Files selected for processing (2)
src/components/ActivityFeed.tsxsrc/components/EmptyState.tsx
Related Issue
Closes #541
Description
This PR improves the Activity Feed UX by introducing a reusable
EmptyStatecomponent for handling zero-data scenarios.Changes Made
EmptyState.tsxcomponentArray.isArray(data)This improves overall user experience and keeps the UI more consistent and informative.
How Has This Been Tested?
Type of Change
Summary by CodeRabbit