Skip to content

improved Sign In button visibility on login page#600

Open
Rashi1404 wants to merge 2 commits into
GitMetricsLab:mainfrom
Rashi1404:fix-signin-button-visibility
Open

improved Sign In button visibility on login page#600
Rashi1404 wants to merge 2 commits into
GitMetricsLab:mainfrom
Rashi1404:fix-signin-button-visibility

Conversation

@Rashi1404
Copy link
Copy Markdown

@Rashi1404 Rashi1404 commented May 28, 2026

Description

This PR improves the visibility and appearance of the Sign In button on the login page.

Changes Made:

  • Reduced the overly dark appearance of the button
  • Improved button contrast and readability
  • Enhanced overall UI consistency of the login form
  • Maintained responsive design compatibility

How Has This Been Tested?

  • Tested the login page locally on different screen sizes
  • Verified button visibility and readability improvements
  • Checked UI responsiveness after styling updates

Screenshots

Screenshot 2026-05-28 at 19 22 32

Type of Change

  • New feature
  • Breaking change
  • Documentation update

Summary by CodeRabbit

  • Style

    • Updated login page button styling with a new slate background and pink border design.
    • Refined login form visual formatting.
  • Chores

    • Updated project dependencies.

Review Change Stack

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for github-spy ready!

Name Link
🔨 Latest commit 6186460
🔍 Latest deploy log https://app.netlify.com/projects/github-spy/deploys/6a18539f9622520008ec1b10
😎 Deploy Preview https://deploy-preview-600--github-spy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Warning

Review limit reached

@Rashi1404, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 17 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 49fbd80c-3530-4a0e-a641-5ae259b7dc0d

📥 Commits

Reviewing files that changed from the base of the PR and between 94a9a4d and 6186460.

📒 Files selected for processing (1)
  • src/pages/Login/Login.tsx
📝 Walkthrough

Walkthrough

This PR adds the @octokit/core dependency to package.json with associated formatting consolidation, and refactors the Login component's Tailwind styling with a visual redesign of the sign-in button from gradient purple/pink tones to slate background with a pink border.

Changes

Package dependency and UI styling updates

Layer / File(s) Summary
Add @octokit/core and format package.json
package.json
Added @octokit/core to dependencies alongside the existing octokit package. Consolidated blank-line spacing in devDependencies and adjusted whitespace at section boundaries.
Login component styling and button redesign
src/pages/Login/Login.tsx
Refactored root container, header, email/password input, and login message className ternaries into compact single-line format while preserving underlying dark/light Tailwind values. Changed sign-in button from purple/pink/indigo gradient background to slate background with pink border and updated focus/hover ring styling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

  • GitMetricsLab/github_tracker#597: Addresses the sign-in button visual redesign by replacing the purple/pink/indigo gradient with slate background and pink border for improved visibility.
  • GitMetricsLab/github_tracker#412: Targets Login UI styling updates by modifying Tailwind className formatting and button design in the same component.

Possibly related PRs

  • GitMetricsLab/github_tracker#138: Modifies src/pages/Login/Login.tsx styling with Tailwind className and button design changes tied to dark/light theme handling.
  • GitMetricsLab/github_tracker#311: Overlaps with button className styling updates including hover/focus/background/border variants in the same Login component.

Suggested labels

level:intermediate, quality:clean, type:accessibility, type:bug

Poem

🐰 A button dressed in slate so fine,
With rosy borders, oh so divine!
Dependencies now complete their dance,
Formatting swept—a tidy stance.
Clean UI code, a rabbit's cheer! 🌷

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description includes most required sections (Description, How Has This Been Tested, Screenshots, Type of Change) but is missing the 'Related Issue' section and has incorrect type of change selections. Add the 'Related Issue' section and correct the type of change checkboxes—this appears to be a code style update, not a new feature or breaking change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: improving the Sign In button visibility, which aligns with the button styling updates from purple/pink gradient to slate background with pink border.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @Rashi1404 for your contribution. Please make sure your PR follows https://github.com/GitMetricsLab/github_tracker/blob/main/CONTRIBUTING.md#-pull-request-guidelines

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/Login/Login.tsx`:
- Line 125: The Sign In button in the Login component is using hardcoded
light-theme classes (bg-slate-100, text-slate-900, border-pink-300); update the
button to apply theme-aware classes based on the existing mode variable (mode
=== "dark") used elsewhere in the component: when mode === "dark" use
dark-friendly classes (e.g., darker bg, light text and muted border) and when
not dark keep the current light classes; modify the className on the Sign In
button (the JSX element rendering the button) to use a ternary or helper that
swaps bg-*, text-*, border-* and corresponding hover/focus ring classes so the
button matches dark-mode styling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9b329f58-3729-40c4-9a0a-3529a01a6998

📥 Commits

Reviewing files that changed from the base of the PR and between 4ae0ef6 and 94a9a4d.

📒 Files selected for processing (2)
  • package.json
  • src/pages/Login/Login.tsx

Comment thread src/pages/Login/Login.tsx Outdated
@Rashi1404
Copy link
Copy Markdown
Author

Description

This PR improves the visibility and appearance of the Sign In button on the login page.

Changes Made:

Reduced the overly dark appearance of the button
Improved button contrast and readability
Enhanced overall UI consistency of the login form
Maintained responsive design compatibility

How Has This Been Tested?

Tested the login page locally on different screen sizes
Verified button visibility and readability improvements
Checked UI responsiveness after styling updates

Screenshots

light mode
Screenshot 2026-05-28 at 19 22 32

dark mode

Screenshot 2026-05-28 at 20 06 33

Type of Change

  • New feature
  • Breaking change
  • Documentation update

@Rashi1404
Copy link
Copy Markdown
Author

@ coderabbitai fixed the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant