Skip to content

Fix annotation hover interaction when card has a target link #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregberge merged 1 commit into from
May 27, 2026
+5 −4
Merged

Fix annotation hover interaction when card has a target link #4274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/gitbook/e2e/internal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,8 +1056,8 @@ const testCases: TestsCase[] = [
url: 'blocks/annotations',
run: async (page) => {
await waitForCookiesDialog(page);
await page.waitForSelector('[data-testid="annotation-button"]');
await page.click('[data-testid="annotation-button"]');
await page.waitForSelector('[data-annotation]');
await page.click('[data-annotation]');
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/gitbook/src/components/DocumentView/Annotation/AnnotationPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function AnnotationPopover(props: { children: React.ReactNode; body: Reac
arrowProps={{ className: 'fill-tint-1' }}
>
<dfn
data-testid="annotation-button"
data-annotation=""
className="cursor-help underline decoration-1 decoration-dotted underline-offset-2"
// biome-ignore lint/a11y/noNoninteractiveTabindex: we want to be able to focus the definition to open the tooltip
tabIndex={0}
Expand Down
3 changes: 2 additions & 1 deletion packages/gitbook/src/components/RootLayout/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@
}

@utility elevate-link {
& a[href]:not(.link-overlay) {
& a[href]:not(.link-overlay),
& [data-annotation] {
position: relative;
z-index: 20;
}
Expand Down
Loading