Workarounds to compile with MPItrampoline#294
Open
nick-wilson wants to merge 11 commits intoGlobalArrays:developfrom
Open
Workarounds to compile with MPItrampoline#294nick-wilson wants to merge 11 commits intoGlobalArrays:developfrom
nick-wilson wants to merge 11 commits intoGlobalArrays:developfrom
Conversation
) error codes are not required to be compile-time constants. see issue and related links for details. fixes GlobalArrays#285 Signed-off-by: Jeff Hammond <jeff.science@gmail.com>
Member
|
thanks. this looks reasonable to me, pending my minor review comments. |
edoapra
reviewed
Aug 4, 2023
| #else | ||
| MPI_Init(argc, argv); | ||
| #endif | ||
| #ifndef MPI_COMM_WORLD |
Contributor
There was a problem hiding this comment.
These three lines don't seem quite right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hacked some workarounds to compile and MPI-PR build of Global Arrays using MPItrampoline https://github.com/eschnett/MPItrampoline
I'm not particularly confident that they are OK.
Can you please take a quick look and advise if there's a better way to do it?