Fix ApplicationConfig format: preserve application: structure on round-trip, warn when sub-files unresolvable

[Copilot]

Opening an ApplicationConfig-format YAML (application: top-level key with workflows[].file references) silently converted it to flat WorkflowConfig on the first onChange event and rendered no sub-file nodes.

Root causes

• parseYaml/parseYamlSafe didn't recognize the application: format — returned an empty config, triggering a silent rewrite on export
• configToYaml, exportMainFileYaml, and buildMainFileContent had no path to emit application: format — always produced flat WorkflowConfig with imports:
• WorkflowStore.exportToConfig() called nodesToConfig() which strips all metadata, losing ApplicationConfig identity across the round-trip

Changes

src/types/workflow.ts

• Add ApplicationConfigMeta interface (name?, version?, workflows: [{file}])
• Add _applicationConfig?: ApplicationConfigMeta to WorkflowConfig (alongside master's _extraTopLevelKeys)

src/utils/serialization.ts

• parseYaml / parseYamlSafe: detect application: format; populate _applicationConfig, imports, name, version
• resolveImports: set _applicationConfig on the returned merged config so format identity survives sub-file resolution
• buildApplicationConfigYaml (new export): round-trips ApplicationConfigMeta → application: YAML
• isMetadataOnlyApplicationConfig (new): returns true when config has no real main-file modules/workflows/triggers/pipelines
• configToYaml: delegates to buildApplicationConfigYaml only when _applicationConfig is present and the config is metadata-only; falls back to full WorkflowConfig serialization otherwise so top-level content is never dropped
• buildMainFileContent: delegates to configToYaml (preserving _extraTopLevelKeys and _originalKeys ordering); clears sub-file-owned workflows/triggers from the main-file view for ApplicationConfig configs so isMetadataOnlyApplicationConfig correctly identifies the main file; importedFiles naturally excludes unresolvable sub-files (files not present in fileModules/filePipelines) preventing empty YAML overwrites

src/stores/workflowStore.ts

• Uses importedPassthrough (from master) to carry all non-visual fields — including _applicationConfig — through the import/export cycle; exportToConfig explicitly reattaches _applicationConfig from importedPassthrough after nodesToConfig

src/components/WorkflowEditor.tsx

• Warning for ApplicationConfig format without a file resolver is keyed off !onResolveFile (not !sourceMapProp) so it fires correctly when a host passes a static sourceMap but no resolver

Example

# Before: opening this file rewrote it on first onChange
application:
  name: my-service
  workflows:
    - file: base.yaml
    - file: users.yaml

# After: exportMainFileYaml / configToYaml preserve the original structure
application:
  name: my-service
  workflows:
    - file: base.yaml
    - file: users.yaml

Two existing tests updated to assert application: format (previously asserted imports:); 22 new tests added in serialization-applicationconfig.test.ts covering ApplicationConfig detection, round-trip, metadata-only guard, and empty-file filtering.

[Copilot]

Pull request overview

This PR adds first-class support for the ApplicationConfig YAML format (application: with workflows[].file references) so the editor can preserve that structure across import → edit → export, and provides user-facing warnings when referenced sub-files can’t be resolved/rendered.

Changes:

• Add ApplicationConfigMeta and persist _applicationConfig metadata through parsing, import resolution, store round-trip, and export.
• Teach serialization/export paths (configToYaml, exportMainFileYaml/exportToFiles) to emit application: YAML when appropriate, plus add a dedicated buildApplicationConfigYaml helper.
• Add/adjust tests to validate ApplicationConfig detection and round-trip behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/utils/serialization.ts	Detect application: format, preserve metadata through resolveImports, and add ApplicationConfig YAML emit paths.
src/utils/serialization-multifile.test.ts	Update multifile expectations to match application: main-file output.
src/utils/serialization-applicationconfig.test.ts	New comprehensive test suite for ApplicationConfig recognition and round-tripping.
src/utils/index.ts	Re-export buildApplicationConfigYaml.
src/types/workflow.ts	Define ApplicationConfigMeta and add _applicationConfig to WorkflowConfig.
src/stores/workflowStore.ts	Preserve ApplicationConfig metadata in store import/export and clear it on reset.
src/components/WorkflowEditor.tsx	Warn when ApplicationConfig is detected but full resolution/rendering isn’t possible.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The warning is meant to trigger when ApplicationConfig is detected but onResolveFile is not provided. This check uses !sourceMapProp, which can suppress the warning when a host passes a sourceMap but no resolver (still cannot resolve referenced sub-files). Consider keying this warning off !onResolveFile (and optionally also when resolver returns missing files).

[intel352]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied all four review comments in commit 7ef4683:

1. configToYaml guard — added isMetadataOnlyApplicationConfig() helper that checks for real modules/workflows/triggers/pipelines; configToYaml now only emits application: format when the config has no main-file content, falling back to full WorkflowConfig serialization otherwise.

2. Empty export files — buildMainFileContent now filters importedFiles to only include files that actually have exported content (modules or pipelines). Files referenced in application.workflows[].file that had no resolvable content are excluded from the export file map, preventing empty YAML overwrites.

3. Warning condition — changed !sourceMapProp → !onResolveFile in WorkflowEditor.tsx. The warning now triggers when there is no file resolver (the actual requirement), regardless of whether a sourceMap prop was passed.

4. Test assertion — replaced the hasAtLeastOneRef check with importedFiles.forEach(f => expect(mainYaml).toContain(f)) so every expected file reference is individually verified.

[intel352]

@copilot Address the merge conflicts intelligently, ensure all tests still pass.

[Copilot]

@copilot Address the merge conflicts intelligently, ensure all tests still pass.

Resolved in commit 90f9ae3. Here's what the merge integrated:

• WorkflowConfig type: both _applicationConfig and _extraTopLevelKeys are now present
• Store: replaced our applicationConfig field with master's importedPassthrough — since importedPassthrough is a spread of the full config (minus visual fields), _applicationConfig is carried automatically; exportToConfig explicitly reattaches it from originalConfig._applicationConfig after nodesToConfig
• serialization.ts: kept all additions from both sides — KNOWN_TOP_LEVEL_KEYS, extractExtraTopLevelKeys, buildApplicationConfigYaml, isMetadataOnlyApplicationConfig; used master's buildMainFileContent (delegate to configToYaml) with one addition: for ApplicationConfig format, workflows and triggers are cleared from mainOnlyConfig before calling configToYaml, since those fields come from sub-files and would otherwise cause isMetadataOnlyApplicationConfig to return false on the merged config

All 4055 tests pass.