fix: resolve sourcery-ai newline issue in TextArea placeholder #315#316
Closed
edehvictor wants to merge 1 commit intoGoodDollar:feat--add-bulk-membersfrom
Closed
fix: resolve sourcery-ai newline issue in TextArea placeholder #315#316edehvictor wants to merge 1 commit intoGoodDollar:feat--add-bulk-membersfrom
edehvictor wants to merge 1 commit intoGoodDollar:feat--add-bulk-membersfrom
Conversation
Collaborator
|
@edehvictor why is this done as separate PR and not as part of the original PR where the AI review came from? |
Author
|
My mistake! Closing this and pushing the commit directly to PR #315. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a UI rendering bug caught by the Sourcery AI automated review on the Bulk Add Members feature.
In
packages/app/src/pages/ManageCollectivePage.tsx, theTextAreaplaceholder was using the HTML entity for a newline. Because React Native does not parse HTML entities in JSX strings, this rendered the literal text on the screen instead of a line break.I updated the placeholder to use a standard template string with an actual newline (
\n), ensuring it renders correctly on both mobile and web.About #314
Related to PR #315
How Has This Been Tested?
yarn workspace @gooddollar/app run web).TextAreaplaceholder text successfully breaks onto a new line without showing raw HTML entities.Checklist:
Summary by Sourcery
Bug Fixes: