Skip to content

fix: resolve sourcery-ai newline issue in TextArea placeholder #315#316

Closed
edehvictor wants to merge 1 commit intoGoodDollar:feat--add-bulk-membersfrom
edehvictor:feat--add-bulk-members
Closed

fix: resolve sourcery-ai newline issue in TextArea placeholder #315#316
edehvictor wants to merge 1 commit intoGoodDollar:feat--add-bulk-membersfrom
edehvictor:feat--add-bulk-members

Conversation

@edehvictor
Copy link

@edehvictor edehvictor commented Feb 23, 2026

Description

This PR resolves a UI rendering bug caught by the Sourcery AI automated review on the Bulk Add Members feature.

In packages/app/src/pages/ManageCollectivePage.tsx, the TextArea placeholder was using the HTML entity 
 for a newline. Because React Native does not parse HTML entities in JSX strings, this rendered the literal text 
 on the screen instead of a line break.

I updated the placeholder to use a standard template string with an actual newline (\n), ensuring it renders correctly on both mobile and web.

About #314
Related to PR #315

How Has This Been Tested?

  • Ran the local development server (yarn workspace @gooddollar/app run web).
  • Navigated to the "Manage Collective" page -> "Member Management" tab.
  • Verified that the TextArea placeholder text successfully breaks onto a new line without showing raw HTML entities.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name (Suggested title: Bug: Fix TextArea newline rendering in ManageCollectivePage)
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (N/A - minor UI string fix)
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • @sirpy

Summary by Sourcery

Bug Fixes:

  • Correct TextArea placeholder formatting so the wallet address examples break onto a new line without showing HTML entity codes.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Feb 23, 2026

@edehvictor why is this done as separate PR and not as part of the original PR where the AI review came from?
should be one and the same PR

@edehvictor
Copy link
Author

My mistake! Closing this and pushing the commit directly to PR #315.

@edehvictor edehvictor closed this Mar 1, 2026
@edehvictor edehvictor reopened this Mar 1, 2026
@edehvictor edehvictor closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants