Fix: fix topAdmins function to use KMS wallet signing

[blueogin]

… enhance logging for KMS configuration

Description

make topAdmins function to use sendTransaction which supports KMS signing

About # (link your issue here)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• PR title matches follow: (Feature|Bug|Chore) Task Name
• My code follows the style guidelines of this project
• I have followed all the instructions described in the initial task (check Definitions of Done)
• I have performed a self-review of my own code
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have added reference to a related issue in the repository
• I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
• I have added screenshots related to my pull request (for frontend tasks)
• I have pasted a gif showing the feature.
• @mentions of the person or team responsible for reviewing proposed changes

Summary by Sourcery

Update blockchain admin wallet handling to support KMS-based transaction signing and improve EIP-1559 chain handling and logging.

Bug Fixes:

• Make the topAdmins operation send transactions via the generic sendTransaction flow so it works correctly with KMS signing.

Enhancements:

• Log the detected chain ID when initializing EIP-1559 gas settings and include the local testnet (4447) in the known EIP-1559 chains list.
• Clarify KMS configuration logging in tests to report the configured key tag.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• The previous txManager.lock around topAdmins has been removed; if multiple workers can still call this concurrently, consider whether you still need some form of nonce/concurrency control to avoid conflicting transactions.
• In topAdmins, sendTransaction is now called with an empty options object; if gas/fee overrides are needed in some environments, consider explicitly documenting or wiring them through rather than relying solely on sendTransaction defaults.
• The console.log('Test chainId', chainId) in Web3Wallet looks like temporary debug output; consider switching this to the existing logger or removing it before merging.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The previous `txManager.lock` around `topAdmins` has been removed; if multiple workers can still call this concurrently, consider whether you still need some form of nonce/concurrency control to avoid conflicting transactions.
- In `topAdmins`, `sendTransaction` is now called with an empty options object; if gas/fee overrides are needed in some environments, consider explicitly documenting or wiring them through rather than relying solely on `sendTransaction` defaults.
- The `console.log('Test chainId', chainId)` in `Web3Wallet` looks like temporary debug output; consider switching this to the existing logger or removing it before merging.

## Individual Comments

### Comment 1
<location path="src/server/blockchain/Web3Wallet.js" line_range="509-512" />
<code_context>
-      } catch (e) {
-        log.error('topAdmins failed', e)
-        fail()
+      log.debug('topAdmins:', { numAdmins, addresses: this.addresses })
+      for (let i = 0; i < numAdmins; i += 50) {
+        log.debug('topAdmins sending tx', { adminIdx: i })
+        await this.sendTransaction(this.proxyContract.methods.topAdmins(i, i + 50), {}, undefined, true, log)
+        log.debug('topAdmins success', { adminIdx: i })
       }
</code_context>
<issue_to_address>
**issue (bug_risk):** Dropping the explicit txManager lock may reintroduce nonce/race issues if topAdmins is invoked concurrently.

Previously this path locked on `this.addresses[0]` and reused a single `nonce` for all batched `topAdmins` calls. Now we depend on `sendTransaction` for nonce handling and no longer serialize via `txManager.lock`. If `topAdmins` can run concurrently across workers/processes, this could lead to nonce collisions or reordered transactions unless `sendTransaction` applies equivalent cross-caller locking. Consider either wrapping this loop in `txManager.lock` or confirming that `sendTransaction` already enforces a global nonce lock for this wallet.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sirpy]

This is not the change i've requested.
Go back to our chat.

[blueogin]

I updated sendTransaction to accept a from address. If it’s defined, the txManager locks that address.