feat(twa-launcher): allow adding extra to twa intent#562
Open
dargmuesli wants to merge 1 commit intoGoogleChrome:mainfrom
Open
feat(twa-launcher): allow adding extra to twa intent#562dargmuesli wants to merge 1 commit intoGoogleChrome:mainfrom
dargmuesli wants to merge 1 commit intoGoogleChrome:mainfrom
Conversation
This was referenced Nov 16, 2025
Allows setting custom headers. Resolves GoogleChrome#329
gstepniewski-google
force-pushed
the
feat/twa-launcher/extra
branch
from
561315a to
0623881
Compare
gstepniewski-google
requested changes
May 6, 2026
| } | ||
| } | ||
|
|
||
| protected TrustedWebActivityIntent getIntent(TrustedWebActivityIntent intent) { |
Collaborator
There was a problem hiding this comment.
Please add javadoc explaining what this method does and how it should be used.
Also consider changing the name to something a little more fitting: getIntent is a method defined by many Android components and used to obtain the starting Intent - meanwhile this one is meant to allow subclasses to customize the Intent before passing it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting custom headers for TwaLauncher.
Resolves #329
See implementation example in: