guard long cast of numeric jwt claim in extractJwtPayload#1016
guard long cast of numeric jwt claim in extractJwtPayload#1016netliomax25-code wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: netliomax25-code The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @netliomax25-code. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
extractJwtPayload renders a numeric JWT claim via static_cast(value.number_value()), but that cast is undefined when the claim is non-finite or outside long's range. A token whose logged number claim is e.g. 1e19 (> LONG_MAX) trips it; under UBSan: "1e+19 is outside the range of representable values of type 'long'". The number comes straight from the client JWT. Guard the narrowing the way JsonStruct::getInteger already does and render the raw value otherwise.