Skip to content

guard long cast of numeric jwt claim in extractJwtPayload#1016

Open
netliomax25-code wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
netliomax25-code:jwt-claim-long-cast
Open

guard long cast of numeric jwt claim in extractJwtPayload#1016
netliomax25-code wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
netliomax25-code:jwt-claim-long-cast

Conversation

@netliomax25-code
Copy link
Copy Markdown

extractJwtPayload renders a numeric JWT claim via static_cast(value.number_value()), but that cast is undefined when the claim is non-finite or outside long's range. A token whose logged number claim is e.g. 1e19 (> LONG_MAX) trips it; under UBSan: "1e+19 is outside the range of representable values of type 'long'". The number comes straight from the client JWT. Guard the narrowing the way JsonStruct::getInteger already does and render the raw value otherwise.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: netliomax25-code
Once this PR has been reviewed and has the lgtm label, please assign gopkarthik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @netliomax25-code. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant