Fix for issue #160 (restored from last year's PR #161)#175
Open
ericdand wants to merge 12 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ericdand The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Note that in this change, since it was such a major change to the |
…che. Warning, may not work: just committing to preserve the first draft before I start editing.
…we need a global FILE variable, despite my reluctance to use global vars.
…ould otherwise appear to be magic.
…uring vibe-coding.
…vering yet another bug from the old code.
…files on disk; additionally add a range guard to cache reads.
… and fix Makefile dependencies
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this change originally to resolve issue #160, but I wrote the change into my master branch. I then used that branch to do some other development, and accidentally wiped out this change. This PR is restored from that old change.
See issue #160 and PR #161 for more background.