Skip to content

Fix for issue #160 (restored from last year's PR #161)#175

Open
ericdand wants to merge 12 commits into
GoogleCloudPlatform:masterfrom
ericdand:restored-fix
Open

Fix for issue #160 (restored from last year's PR #161)#175
ericdand wants to merge 12 commits into
GoogleCloudPlatform:masterfrom
ericdand:restored-fix

Conversation

@ericdand
Copy link
Copy Markdown
Contributor

I wrote this change originally to resolve issue #160, but I wrote the change into my master branch. I then used that branch to do some other development, and accidentally wiped out this change. This PR is restored from that old change.

See issue #160 and PR #161 for more background.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericdand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericdand
Copy link
Copy Markdown
Contributor Author

Note that in this change, since it was such a major change to the src/nss/nss_cache_oslogin.c file, also adjusts the line spacing from two spaces to four, following the Google style guide. I recommend using "ignore whitespace" while reviewing the change, to better see what has changed.

@ericdand
Copy link
Copy Markdown
Contributor Author

ericdand commented May 5, 2026

This PR has now been rebased to include Ana's new "binary cache" from earlier this year. It additionally includes some changes from my recent pull requests, PR #184 and PR #185, which should probably get merged (and then folded into this PR again) first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant