circuit-tracer integration for CrossLayerTranscoders#8
Open
jiito wants to merge 104 commits into
Open
Conversation
…into conversion-to-circuit-tracer
circuit-tracer integrationcircuit-tracer integration for CrossLayerTranscoders
…into conversion-to-circuit-tracer
…ranscoder into conversion-to-circuit-tracer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ModelConverterand concreteCircuitTracerConverterthat is used to turn aCLTModuleinto circuit tracer compatible format.circuit-tracer.Questions
circuit-tracercompatible model? Which callback to attach it to in the checkpoint? I have made this configurable with config argumentsthreshold? The circuit tracer expects a[1, d_features]tensor for each layer's non-linearity. Right now, I am usingmodel.nonlinearity.theta[:, layer_idx, :]but this doesn't account for the bandwidth...ModelConverterinterface? This is maybe better framed as aModuleSaver? I am planning for using this same interface for delphi and other integrations.Verification
ModelConversionCallbackmanuallycircuit-tracer.yaml) and loading the saved model.Resolves #4
Future Work