Fix indexing in extract_annotation_from()#84
Open
gruberchr wants to merge 1 commit intoGothenburgBitFactory:mainfrom
Open
Fix indexing in extract_annotation_from()#84gruberchr wants to merge 1 commit intoGothenburgBitFactory:mainfrom
gruberchr wants to merge 1 commit intoGothenburgBitFactory:mainfrom
Conversation
json_obj['annotations'] contains the annotations in chronological order, i.e., the first annotation is the oldest, and the last annotation is the latest. In order to recognize any changes to the annotations and provide Timewarrior with the latest annotation, the last annotation with index -1 should be returned instead of the first one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIKS
json_obj['annotations']contains the annotations in chronological order, i.e., the first annotation is the oldest, and the last annotation is the latest.I assume that in order to recognize any changes to the annotations and provide Timewarrior with the latest annotation, the last annotation with index -1 should be returned instead of the first one.