prs: surface real gh CLI error instead of generic auth message#1813
Open
adagr8-web wants to merge 1 commit into
Open
prs: surface real gh CLI error instead of generic auth message#1813adagr8-web wants to merge 1 commit into
adagr8-web wants to merge 1 commit into
Conversation
_gh() previously collapsed every failure mode (nonzero exit, timeout, bad JSON, missing binary) into a bare None, so fetch_prs() always raised the same 'gh CLI not found or not authenticated' RuntimeError regardless of the actual cause. This made a wrong --repo value (or any other real failure) indistinguishable from an auth problem, leading to hours of debugging auth/PATH/env when the server-side setup was correct the whole time. Now _gh() optionally collects the real stderr/exception detail via an _errors list, and fetch_prs() surfaces it in the exception message. Fully backward compatible — callers that don't pass _errors behave exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_gh() previously collapsed every failure mode (nonzero exit, timeout, bad JSON, missing binary) into a bare None, so fetch_prs() always raised the same 'gh CLI not found or not authenticated' RuntimeError regardless of the actual cause. This made a wrong --repo value (or any other real failure) indistinguishable from an auth problem, leading to hours of debugging auth/PATH/env when the server-side setup was correct the whole time.
Now _gh() optionally collects the real stderr/exception detail via an _errors list, and fetch_prs() surfaces it in the exception message. Fully backward compatible — callers that don't pass _errors behave exactly as before.