Ensure DQS lines up when missing Nsw values in impacts tab excel export #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msrocka
reviewed
Jan 16, 2026
| NwFactor nwFactor = nwSet.getFactor(impact); | ||
| if (nwFactor == null) | ||
| if (nwFactor == null) { | ||
| // Write empty cells to maintain alignment if there is no normalization/single score/weighting factor |
Member
There was a problem hiding this comment.
Is this really true or is it just the AI thinkig so? If I am correct, it is not required to create empty cells for whatever alignment. So a simple return col + 3 would be enough. If the comment was written by a human, I would trust that they really run into an issue and had to add this as a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the DQS lines up in excel export if there is no Nsw (normalised, single score or weighed) values for a characterisation factor in the impact results (EF 3.1 for breakdowns in climate change, ecotoxicity, etc)
Before:
Now:
