Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Jan 16, 2026

Remove GameObjectArrayMap in favour of GameObjectHashMap
For normal/low mem mode:

  • 500ms/120ms slower on first start
  • 250ms/275ms faster on subsequent starts
  • 105mb/0mb reduction in ram usage
  • 52mb/26mb increased disk usage
  • Minimal performance impact as object data isn't read frequently.

@github-actions
Copy link
Contributor

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 5.61798% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.58%. Comparing base (794ef40) to head (c50da72).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...gs/voidps/engine/map/collision/CollisionDecoder.kt 0.00% 32 Missing ⚠️
...gs/voidps/engine/data/definition/MapDefinitions.kt 0.00% 31 Missing ⚠️
...regs/voidps/engine/entity/obj/GameObjectHashMap.kt 20.00% 16 Missing ⚠️
...tlin/world/gregs/voidps/engine/data/ConfigFiles.kt 0.00% 2 Missing ⚠️
...orld/gregs/voidps/engine/entity/obj/GameObjects.kt 33.33% 2 Missing ⚠️
game/src/main/kotlin/Main.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
game/src/main/kotlin/Main.kt 0.00% <0.00%> (ø)
...tlin/world/gregs/voidps/engine/data/ConfigFiles.kt 9.61% <0.00%> (ø)
...orld/gregs/voidps/engine/entity/obj/GameObjects.kt 63.38% <33.33%> (-0.15%) ⬇️
...regs/voidps/engine/entity/obj/GameObjectHashMap.kt 39.47% <20.00%> (-5.99%) ⬇️
...gs/voidps/engine/data/definition/MapDefinitions.kt 1.53% <0.00%> (-0.25%) ⬇️
...gs/voidps/engine/map/collision/CollisionDecoder.kt 42.85% <0.00%> (-26.38%) ⬇️

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #833      +/-   ##
============================================
- Coverage     37.64%   37.58%   -0.06%     
+ Complexity     7514     7507       -7     
============================================
  Files          1492     1491       -1     
  Lines         59282    59309      +27     
  Branches      14831    14839       +8     
============================================
- Hits          22314    22291      -23     
- Misses        32020    32071      +51     
+ Partials       4948     4947       -1     
Components Coverage Δ
Content 35.09% <0.00%> (+<0.01%) ⬆️
Engine 42.79% <5.68%> (-0.33%) ⬇️
Network 60.93% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 81f84da into main Jan 16, 2026
5 checks passed
@GregHib GregHib deleted the map-caching branch January 16, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants