fix(descriptions): fix French gender agreement in "no description" message#1428
Merged
Conversation
ClemRz
approved these changes
Jun 28, 2026
ClemRz
left a comment
Contributor
There was a problem hiding this comment.
Suggestions (Should Consider)
- [packages/web-app/public/lang/it.json, de.json, pt.json, nl.json] The Italian, German, Portuguese, and Dutch translations currently use a short generic phrase (e.g., "Nessuna descrizione", "Keine Beschreibung") identical for all three keys. These languages also have grammatical gender. Consider providing full sentences matching the style of fr/es/en for a better user experience — though this is not blocking since the current translations are grammatically correct on their own (they just don't mention the entity type). This can be addressed in a follow-up.
Nitpicks (Optional)
- General Nice, minimal change. The approach of splitting into entity-specific keys (
descriptions.none.{cave,entrance,massif}) is cleaner than trying to handle grammatical gender through ICU message syntax. Good use of the constrainedentityTypeprop to build the key dynamically.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
323c5b7 to
584cc28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(descriptions): fix French gender agreement in "no description" message
🤔 What
Fix the French (and Spanish) translation of the "no description" alert in the
Descriptionscomponent so it correctly matches the grammatical gender of each entity type."Il n'y a actuellement aucune description pour ce entrée."❌ (wrong gender + wrong article)"Il n'y a actuellement aucune description pour cette entrée."✅🤷♂️ Why
The previous i18n key
descriptions.noneused a single{entityType}placeholder, which forced a single article (ce) for all entity types. In French, the article depends on grammatical gender:cette entrée(feminine)cette cavité(feminine)ce massif(masculine)Same issue existed in Spanish (
esta/este).Closes #1425.
🔍 How
Replaced the single
descriptions.nonekey with three entity-specific keys:descriptions.none.entrancedescriptions.none.cavedescriptions.none.massifThe component now uses
`descriptions.none.${entityType}`as the message id — no more runtime parameter injection for the entity name.All 15 language files updated. Languages that didn't differentiate by entity type (ar, bg, ca, de, el, he, id, it, ja, nl, pt, ro) keep the same text for all three keys.
🔗 Related API PR
N/A
🧪 Testing
Navigate to an entrance, cave, or massif that has no description and verify the alert text is grammatically correct in French.
📸 Previews
Before (wrong):