fix(map): adapt map height to adjacent content#1429
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What
Closes #1426
🤷♂️ Why
When the adjacent content (localisation, characteristics, vigilance points, data quality…) exceeds 400px, the map container was left with a visible blank area underneath, creating an unbalanced layout.
🔍 How
Single-line change in
MapContainer.jsx: replaced the fixedheight: 400pxwithheight: 100%; min-height: 400px.The parent
HalfSplitContaineralready usesalign-items: stretch(flex row on desktop), so both columns grow to the same height. Switching the map wrapper toheight: 100%lets it fill that stretched height rather than staying capped at 400px.On mobile (stacked column layout), the parent has no fixed height, so
height: 100%would collapse —min-height: 400pxacts as the floor, preserving the existing mobile behaviour.🔗 Related API PR
N/A
🧪 Testing
Open an entrance page where the right-hand panel is tall (e.g. https://grottocenter.org/ui/entrances/2772) and verify there is no blank space below the map.
📸 Previews