Skip to content

fix(map): adapt map height to adjacent content#1429

Merged
Paul-AUB merged 1 commit into
developfrom
feat/map-height
Jun 28, 2026
Merged

fix(map): adapt map height to adjacent content#1429
Paul-AUB merged 1 commit into
developfrom
feat/map-height

Conversation

@Paul-AUB

@Paul-AUB Paul-AUB commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

🤔 What

  • The map height on entrance and cavity pages now adapts to the height of the adjacent content panel
  • Removes the empty space that appeared below the map when the information panel was taller than 400px

Closes #1426

🤷‍♂️ Why

When the adjacent content (localisation, characteristics, vigilance points, data quality…) exceeds 400px, the map container was left with a visible blank area underneath, creating an unbalanced layout.

🔍 How

Single-line change in MapContainer.jsx: replaced the fixed height: 400px with height: 100%; min-height: 400px.

The parent HalfSplitContainer already uses align-items: stretch (flex row on desktop), so both columns grow to the same height. Switching the map wrapper to height: 100% lets it fill that stretched height rather than staying capped at 400px.

On mobile (stacked column layout), the parent has no fixed height, so height: 100% would collapse — min-height: 400px acts as the floor, preserving the existing mobile behaviour.

🔗 Related API PR

N/A

🧪 Testing

Open an entrance page where the right-hand panel is tall (e.g. https://grottocenter.org/ui/entrances/2772) and verify there is no blank space below the map.

📸 Previews

image

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Paul-AUB Paul-AUB self-assigned this Jun 28, 2026
@Paul-AUB Paul-AUB requested review from ClemRz and urien June 28, 2026 15:14

@urien urien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est parfait. Merci @Paul-AUB

@Paul-AUB Paul-AUB merged commit 42ef484 into develop Jun 28, 2026
8 of 9 checks passed
@Paul-AUB Paul-AUB deleted the feat/map-height branch June 28, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapter la hauteur de la carte a la hauteur des éléments adjacents

2 participants