added background color and text color to tab label#2236
added background color and text color to tab label#2236selam wants to merge 2 commits intoGuake:masterfrom
Conversation
Davidy22
left a comment
There was a problem hiding this comment.
Just on a first impression from building and trying it out, the tabs are visibly compressed horizontally which I'm not quite sure I like, and the tab colors don't fill the full tab which makes it look like weird little flat squares in the middle of each tab. The flat color is a little jarring against the gradients that most themes apply to the tab bar, some transparency in the applied color box might be good. Clicking the cancel button breaks the dialog until the user opens the color picker dialog again.
|
you are right, coloring tabs looks very weird and i suspect themes couse of that, i can't figure out how to fix it, i send this patch as a feature request and a example. as a web developer i dont have enough experience and knowlage about gtk :( latest commit fix the usage of cancel button of color picker |
|
I notice in the commit there's some fiddling with dimensions and border being done, can try adjusting that and maybe padding, etc. For working with themes, I did mention earlier you could try making the colors semi-transparent so that they act more like a tint than a solid colored box. Also, would be nice if you could run |
this patch adds custom background and text color to tabs,
i am not good at gtk library and related tech, i just want to custom colored tabs, instead of label maybe for tab style more good idea to change colors