Created style guide for common elements [Closes #15]#19
Open
Moniarchy wants to merge 1 commit intoGuildCrafts:masterfrom
Moniarchy:15-style-guide
Open
Created style guide for common elements [Closes #15]#19Moniarchy wants to merge 1 commit intoGuildCrafts:masterfrom Moniarchy:15-style-guide
Moniarchy wants to merge 1 commit intoGuildCrafts:masterfrom
Moniarchy:15-style-guide
Conversation
jrobcodes
suggested changes
Nov 3, 2016
Contributor
jrobcodes
left a comment
jrobcodes
left a comment
There was a problem hiding this comment.
Some formatting changes requested. As well, can we organize the CSS into logical files? There's a lot going on in that file and it would be easier to absorb if there were less of it, in appropriately named files. Also, I don't think it's BEM, so we should talk about the approach.
| "react-dom": "^15.3.2", | ||
| "react-router": "^2.6.1" | ||
| "react-router": "^2.6.1", | ||
| "sass": "^0.5.0" |
Contributor
There was a problem hiding this comment.
This is probably a dev dependency. Also, it doesn't look like we're using SASS?
| response.render('index', { title: 'Lizardboard' }); | ||
| }); | ||
|
|
||
| router.get('/styleguide', ( request, response, next ) => { |
Contributor
There was a problem hiding this comment.
Trivial whitespace changes for this route: please insert spaces between parens and params, here and in response.render
views/styleguide.pug
Outdated
| .body-div | ||
| h1.header Styleguide | ||
| h2.heading Colors | ||
| .color-div |
Contributor
There was a problem hiding this comment.
Do you hate me, whitespace, or both? :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.