Skip to content

Conversation

@Armitryx
Copy link
Contributor

@Armitryx Armitryx commented May 17, 2025

This pull request introduces several new features and improvements, focusing on adding a new chess opening training page, enhancing the board component's functionality, and updating the navigation menu. Key changes include the implementation of a new OpeningPage for learning chess openings, support for visual feedback on the board, and the addition of Italian game variations.
Player avatars were removed from the Play and Opening sections (useless since you’re playing against the bot). Commit 419f0e8

Improvements needed :

Avoid vertical scrolling (I'm going crazy)

@Armitryx Armitryx marked this pull request as draft May 17, 2025 12:36
@GuillaumeSD
Copy link
Owner

Hi @Speedauge, thanks for the PR 👍
This will definitely hype the community 🔥
We should try to keep this PR simple and small so it's easier to merge and have some solid foundations to build upon.
That's why, I would ask you to not do #3 (add other openings) and #5 (the feedback button) in this PR. They can be added later in future PRs.
Imo you should focus on cleaning and fixing what you have already built. Then when you are happy about it : ping me and I'll merge and improve/fixing the remaining bugs. For instance, like we discussed, I can handle #2 (sizing issue) when I'll merge this PR, you don't need to worry too much about it ✌️

@Armitryx Armitryx force-pushed the Openning-trainer branch from 56aefa2 to 7e55a89 Compare May 18, 2025 20:18
@Armitryx
Copy link
Contributor Author

Horizontal *

@Armitryx Armitryx marked this pull request as ready for review May 19, 2025 17:34
…s in Analysis page

- Restored conditional rendering to hide the progress bar when value is zero, matching original behavior.
- Updated project by syncing with upstream repository and resolved merge conflicts.
- Ensured consistency in constants and styling across components.
@Armitryx Armitryx changed the title Openning Trainer Opening Trainer May 31, 2025
@Armitryx Armitryx closed this May 31, 2025
@Armitryx Armitryx deleted the Openning-trainer branch May 31, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants