Closed
Conversation
To avoid confusion, since fNEff2 is unrelated to fDarkRate2 or fNPMTs2. Also includes changes to whitespace and comments.
see discussion at HKDAQ#12
as suggested by @gpronost
Thanks to @gpronost!
* Add function to overwrite neighbour tree + quiet mode to minimize debug * Replace Quiet mode by negative verbosity * Replace if ( fVerbosity ) by if ( fVerbosity > 0 ) * Replace if ( fVerbosity ) by if ( fVerbosity > 0 ) * Remove Overwrite function, fix missing verbosity flag * Update WCSimFLOWER.h
* Add function to overwrite neighbour tree + quiet mode to minimize debug * Replace Quiet mode by negative verbosity * Replace if ( fVerbosity ) by if ( fVerbosity > 0 ) * Replace if ( fVerbosity ) by if ( fVerbosity > 0 ) * Remove Overwrite function, fix missing verbosity flag * Update WCSimFLOWER.h * Add configurations used for MC Production * Correct Neighbour distance for Hybrid 40pc * Remove debug
* Update mPMT numbers after PMT mask applied * Add full support for PMT mask * One nPMT_nomask was missing * Check PMT Mask was not correctly done (need TubeID) * Debug GetNearestNeighbours with Verbose is set * Solve issue in GetNearestNeighbours
* Add ROOT File close() in order to prevent some (rare) cases of ROOT File corruption * Add case for hybrid geometry in CorrectEnergy function
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.