-
Notifications
You must be signed in to change notification settings - Fork 4
Integrate quality checks and enhance ISMS policy references with specific versions #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… alignment Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
|
@copilot repo agents cant have mcp servers. and do a full review of all agents, see package.json . analyse all *.md files. Donwload an analyse HAck23 ISMS. See copilot workflow setup |
Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Fixed in commit 1a3c93e: ✅ Removed all MCP server configurations from repository-level agents - Per GitHub Copilot docs, repo agents cannot have MCP servers (only org-level agents in ✅ Updated ISMS to v3.2, 2026 - Analyzed ISMS-PUBLIC, current version is v3.2 effective 2026-01-25 ✅ Analyzed package.json - All agents now reference relevant npm scripts:
✅ *Reviewed all .md files - Updated descriptions, removed verbose MCP usage sections, added Quality Checks sections ✅ Reviewed copilot workflow setup - Verified Node.js 24, npm ci, caching configured correctly ✅ Added explanation - Agent README now clarifies MCP servers are repo-level configuration in |
|
@copilot Actually download https://github.com/Hack23/ISMS-PUBLIC/blob/main/Secure_Development_Policy.md , review complete document and make sure all agents use and reference it and other Hack23 ISMS policies(all with different versions, but do never need to be included) . improve all |
…ve security standards Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Completed in commit 4daa90d: ✅ Downloaded and analyzed complete Secure Development Policy (v2.1, 1201 lines, effective 2026-01-25) ✅ All agents now reference specific policy versions:
✅ Added Security Standards sections to all development agents (game-developer, frontend-specialist, test-engineer) covering:
✅ Enhanced security-specialist with comprehensive policy references (4 different ISMS policies) and detailed requirements ✅ Improved all agents with:
Key improvements: Every quality check now explicitly references which policy mandates it, making compliance auditable and clear. |
Agents didn't reference package.json quality checks and ISMS policy references were outdated. Initial implementation incorrectly added MCP server configurations to repository-level agents, which has been corrected.
Changes
Quality Checks Integration
npm run lint,npm run buildnpm run test,npm run coverage(80%+ target)npm run test:e2enpm audit,npm run test:licensesISMS Compliance Enhancement
Agent Architecture Correction
.github/copilot-mcp.jsonand are available to all agentsSize Optimization
Files Modified
.github/copilot-instructions.md- Quality checks and security section with specific policy versions.github/agents/- All 6 agent files (quality checks, specific ISMS versions, security standards, removed MCP configs).github/agents/README.md- Added MCP architecture explanation, updated with policy versionsREADME.md- Updated agent description with ISMS v3.2Stats: 8 files, +208/-181 lines across 3 commits
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.