Manually implement GetHashCode on Vector4Double and Vector4Triple#1
Open
gamma-delta wants to merge 1 commit intoHackerPoet:mainfrom
Open
Manually implement GetHashCode on Vector4Double and Vector4Triple#1gamma-delta wants to merge 1 commit intoHackerPoet:mainfrom
gamma-delta wants to merge 1 commit intoHackerPoet:mainfrom
Conversation
This makes having many shadows in a scene MUCH more performant.
Owner
|
Thanks, I've just tested this and it indeed seems to have a major speedup in mesh generation. I had no idea that this wasn't the default behavior in C#. I'll add this in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source
In my experiments this makes generating a mesh for a 6x6x6x1 grid of unit hypercubes go from ~3 seconds to 0.006 seconds!