fix: replace premium GSAP SplitText with split-type, fix globe init race condition#8
Open
pro-utkarshM wants to merge 1 commit intoHackerResidency:mainfrom
Open
fix: replace premium GSAP SplitText with split-type, fix globe init race condition#8pro-utkarshM wants to merge 1 commit intoHackerResidency:mainfrom
pro-utkarshM wants to merge 1 commit intoHackerResidency:mainfrom
Conversation
|
@pro-utkarshM is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
The website was crashing with client-side exceptions, most notably:
The codebase also relied on
gsap/SplitText, a paid GSAP Club plugin, causing licensing and build issues.Changes
1. Replace GSAP SplitText with split-type
File:
src/app/home/animated-story-text.tsxgsap/SplitTextdependencysplit-typesplit-typeAPI2. Fix Globe WebGL initialization race condition
File:
src/components/globe.tsxisMountedguard to ensure component is fully mounted before WebGL initrequestAnimationFrameto ensure correct canvas dimensionstry/catchfor graceful error handlingFiles Changed
package.jsonsplit-typedependencypnpm-lock.yamlsrc/app/home/animated-story-text.tsxsrc/components/globe.tsxTesting
pnpm buildpasses