Skip to content

fix(hsts): only award preload bonus when max-age meets the hstspreload.org 2-year minimum #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmchaledev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(hsts): only award preload bonus when max-age meets the hstspreload.org 2-year minimum #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,16 @@ export function checkHSTS(headers: RawHeaders): HeaderFinding {
if (maxAge > 0) {
if (/includesubdomains/i.test(raw)) { score += 3; }
else { findings.push('includeSubDomains not set'); recommendations.push('Add includeSubDomains directive'); }
if (/preload/i.test(raw)) score += 2;
if (/preload/i.test(raw)) {
// hstspreload.org requires max-age >= 63072000 (2 years). Award the bonus
// only when the site meets that threshold; otherwise surface a finding.
if (maxAge >= 63072000) {
score += 2;
} else {
findings.push(`preload is set but max-age=${maxAge} is below the 63072000 (2 year) minimum required by hstspreload.org`);
recommendations.push('Set max-age=63072000 to meet the HSTS preload minimum');
}
}
}

return { header: 'Strict-Transport-Security', score, maxScore: 20, status: score >= 15 ? 'good' : 'warning', raw, findings, recommendations };
Expand Down
18 changes: 12 additions & 6 deletions test/analyzer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ describe('checkHSTS', () => {
});

it('full HSTS returns score 20', () => {
const r = checkHSTS({ 'strict-transport-security': 'max-age=31536000; includeSubDomains; preload' });
const r = checkHSTS({ 'strict-transport-security': 'max-age=63072000; includeSubDomains; preload' });
expect(r.score).toBe(20);
expect(r.status).toBe('good');
});
Expand All @@ -96,14 +96,20 @@ describe('checkHSTS', () => {
expect(r.score).toBe(15);
});

it('preload adds 2 bonus points', () => {
const withPreload = checkHSTS({ 'strict-transport-security': 'max-age=31536000; includeSubDomains; preload' });
const withoutPreload = checkHSTS({ 'strict-transport-security': 'max-age=31536000; includeSubDomains' });
it('preload adds 2 bonus points when max-age meets the 2-year requirement', () => {
const withPreload = checkHSTS({ 'strict-transport-security': 'max-age=63072000; includeSubDomains; preload' });
const withoutPreload = checkHSTS({ 'strict-transport-security': 'max-age=63072000; includeSubDomains' });
expect(withPreload.score).toBe(withoutPreload.score + 2);
});

it('preload with max-age < 2 years triggers a finding instead of a bonus', () => {
const r = checkHSTS({ 'strict-transport-security': 'max-age=31536000; includeSubDomains; preload' });
expect(r.findings.some(f => /preload/i.test(f))).toBe(true);
expect(r.score).toBe(18); // 10 base + 5 (1yr) + 3 (includeSubDomains), no preload bonus
});

it('case-insensitive header name matching', () => {
const r = checkHSTS({ 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains; preload' });
const r = checkHSTS({ 'Strict-Transport-Security': 'max-age=63072000; includeSubDomains; preload' });
expect(r.score).toBe(20);
});

Expand Down Expand Up @@ -514,7 +520,7 @@ describe('checkCrossOriginPolicies', () => {
describe('grade boundaries', () => {
it('A+ at 90%', () => {
const headers = {
'strict-transport-security': 'max-age=31536000; includeSubDomains; preload',
'strict-transport-security': 'max-age=63072000; includeSubDomains; preload',
'content-security-policy': "default-src 'self'; form-action 'self'; base-uri 'self'",
'x-frame-options': 'DENY',
'x-content-type-options': 'nosniff',
Expand Down
Loading