fix(comfyui): real ComfyUI link + workflow tags open the editor#881
Merged
Conversation
The dashboard ComfyUI card derived its open-link from the /status
`endpoint` field (":8188"), which old code turned into
http://127.0.0.1:8188 — the *server's* loopback, dead from a browser.
And the six workflow tags POSTed to /workflows/{name}/launch with names
("qwen-image"…) that don't match the real files, so they 404'd silently
— the "tags aren't linked" report.
- Backend: /api/config/urls now returns a `comfyui` key (env
HAL0_COMFYUI_PUBLIC_URL, else http://<request-host>:8188, proxy-aware,
port-stripped behind a proxy) — mirroring the openwebui pattern so a
reverse-proxy deploy can hand back a clean HTTPS URL and avoid the
mixed-content block an HTTPS dashboard hits on a bare :8188 link.
- Frontend: comfyBaseUrl now comes from useConfigUrls().comfyui (with a
window.location:8188 fallback for the pre-config tick), not the dead
loopback. The workflow tags become anchor links that open ComfyUI's
editor (matching the block's "opens in ComfyUI ↗" label) instead of
the broken headless launch. Each carries a forward-compatible
?workflow=<file> breadcrumb (ComfyUI#9858) pointing at the curated
workflow — ignored by current ComfyUI, auto-upgrades to a true
deep-link if upstream ships it.
True per-workflow auto-open via URL is upstream-blocked
(Comfy-Org/ComfyUI#9858); tags open the editor where the curated
workflows are now pickable. Backend launch route kept (still tested).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The dashboard ComfyUI card's open-link came from the
/statusendpointfield (":8188"), which old code turned intohttp://127.0.0.1:8188— the server's loopback, dead from a browser. And the six workflow tags POSTed to/workflows/{name}/launchwith names (qwen-image…) that don't match the real workflow files, so they 404'd silently. Together: "the workflow tags aren't linked."What
/api/config/urls): newcomfyuikey —HAL0_COMFYUI_PUBLIC_URLenv override, elsehttp://<request-host>:8188, proxy-aware (port-stripped behind a proxy). Mirrors the existingopenwebuipattern so a reverse-proxy deploy can advertise a clean HTTPS URL and avoid the mixed-content block an HTTPS dashboard hits on a bare:8188link.comfyBaseUrlnow derives fromuseConfigUrls().comfyui(with awindow.location:8188fallback for the pre-config tick), not the dead loopback. The workflow tags are now anchor links that open ComfyUI's editor (matching the block's own "opens in ComfyUI ↗" label) instead of the broken headless launch. Each carries a forward-compatible?workflow=<file>breadcrumb pointing at the curated workflow.Upstream note
True per-workflow auto-open via URL is blocked upstream (comfyanonymous/ComfyUI#9858). The
?workflow=param is ignored by current ComfyUI (link opens the editor, where the curated workflows are now pickable) and auto-upgrades to a true deep-link if/when #9858 ships. The backend launch route is left in place (still tested).Tests
comfyuiURL (LAN-direct :8188, env override wins, proxy without env).test_config_urls.py13/13 green.comfyui-arbiter-v3e2e: workflow chip is now an anchor opening ComfyUI in a new tab. Affected specs 17/17 green;npm run build+tsc --noEmitclean.Related runtime fix (already applied on CT105, not in this PR)
The 10 curated workflows (Qwen-Image, Wan2.2, LTX2, Hunyuan) were saved in ComfyUI API format in the editor's
user/default/workflowsdir, so ComfyUI's workflow browser rendered them blank. Converted in place to graph format via ComfyUI's ownloadApiJson(backup atworkflows.api-bak). They now open as real graphs.🤖 Generated with Claude Code