feat/fix: Space dragon devour action refactor#2025
Open
re-silvered wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes the devour action for space dragons so that devoured walls are actually deleted on after the action, preventing issues with occlusion being placed inside the dragon and preventing vision, plus a million walls popping up wherever their body is cut open
Why / Balance
Bugfix
Technical details
Replaces the entity filter for creatures from
HumanoidAppearanceComponentwithMobStateComponentinstead to filter all potentially edible creatures to be inserted into the stomach, with any other entity able to be devoured (some wall structures) are queued for deletion as intended. Healing(ichor) is injected no matter what is eaten, and whether it's immediately deleted or moved to stomach.How to test
Control a space dragon -> use the devour action on some walls -> see that you're still given ichor as appropriate, and that the entity isn't placed inside the stomach container.
Changelog
🆑