feat: Cleanup round-critical items during cc intermission period#2040
Open
re-silvered wants to merge 1 commit into
Open
feat: Cleanup round-critical items during cc intermission period#2040re-silvered wants to merge 1 commit into
re-silvered wants to merge 1 commit into
Conversation
Update GameTicker.RoundFlow.cs
660cf8f to
749a93b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Modifies my existing roundflow code to delete a list of shift-specific items instead of only the rescue beacon to currently the following items:
Any other items I may be forgetting please do suggest.
Why / Balance
Some shift-specific items have the potential to or do break the natural progression of the next shift if they are brought into it
Technical details
Adds a method called QueueDeleteEntities that parses through every entity and deletes the ones that match items in a list.
The method is ran at the same time in the inter-round cleanup as the previous map's deletion.
How to test
Call evac to begin EoR flow -> spawn the targeted items -> wait for next station to spawn -> see that the targeted items are deleted, and that the targeted items on the new map are not.
Breaking changes
Review the list of items cleaned up, it has the potential to affect EoR roleplay.
Changelog
🆑