Conversation
This commit fixes several critical issues preventing the Android build from working: 1. Add missing whisper.cpp submodule at android/lib/whisper.cpp - The CMakeLists.txt expects whisper.cpp at this location - Updated .gitmodules to reflect correct path 2. Fix invalid Android Gradle Plugin version - Changed from 8.13.0 (non-existent) to 8.1.1 (stable) - Updated Kotlin version from 2.2.0 to 2.0.0 for compatibility 3. Fix invalid SDK versions - Reduced compileSdk from 36 to 34 (SDK 36 doesn't exist) - Reduced targetSdk from 36 to 34 - Updated buildToolsVersion from 36.0.0 to 34.0.0 4. Make gradlew executable - Fixed permissions on android/gradlew script The build should now work once dependencies can be downloaded from Maven repositories.
Fixed CMake errors by updating source file paths to match the current whisper.cpp repository structure. The ggml library was recently refactored and many files were renamed/moved. Changes: - Added missing ggml.cpp and ggml-opt.cpp - Updated ggml-cpu file paths: * ggml-cpu-hbm.cpp → hbm.cpp * ggml-cpu-quants.c → quants.c * ggml-cpu-traits.cpp → traits.cpp * Removed non-existent ggml-cpu-aarch64.cpp - Added new required files: * repack.cpp, vec.cpp, ops.cpp - Added ARM architecture-specific files from arch/arm/ subdirectory - Added include directory for ARM architecture files This resolves CMake errors: "Cannot find source file" and "No SOURCES given"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.