Skip to content

some better tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kcassam wants to merge 10 commits into
base: recette
Choose a base branch
from
Open

some better tests #4

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7a7c211
some better tests
kcassam Aug 28, 2017
02bb112
should work in php 5.6
kcassam Aug 28, 2017
3949db1
should pass 5.4.4
kcassam Aug 28, 2017
5d97983
php 5.4
kcassam Aug 28, 2017
b714ee4
5.4 not OK with alorel/dropbox-v2-php dependencies (guzzle)
kcassam Aug 29, 2017
5c2b17f
5.5 not ok for phpunit
kcassam Aug 29, 2017
e9a3bfb
let's clearly specify php version minimum requirement
kcassam Aug 29, 2017
e2a7acb
After discussion, we do not require php >=5.6
kcassam Aug 29, 2017
91ab626
we test Folder::next in 3 different situations
kcassam Aug 29, 2017
45f4602
due to race condition, I do not test Folder::next should return null
kcassam Aug 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions tests/DropboxHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ class DropboxHelperTest extends TestCase
/** @var string $sFolderPath: Path of folder on Dropbox */
protected $sFolderPath = '/PathToTest/OnYourDropbox';

/** @var string : Cursor of the $sFodlerPath. We'll get only delta */
protected $sCursor = 'AAHeJvp9Yce1wS7YPADH7A-----';

/** @var DropboxHelper */
protected $dropboxHelper = null;

Expand All @@ -20,7 +17,6 @@ public function setUp()
$env = array_merge($_ENV, $_SERVER);

$this->sFolderPath = (isset($env['DROPBOX_FOLDER_PATH'])) ? $env['DROPBOX_FOLDER_PATH'] : null;
$this->sCursor = (isset($env['DROPBOX_FOLDER_CURSOR'])) ? $env['DROPBOX_FOLDER_CURSOR'] : null;

if (isset($env['DROPBOX_TOKEN'])) {
$this->dropboxHelper = new DropboxHelper($env['DROPBOX_TOKEN']);
Expand All @@ -34,8 +30,17 @@ public function setUp()
*/
public function testGetCurrentAccount()
{
$result = $this->dropboxHelper->getCurrentAccount();
self::assertNotNull($result, 'Cannot get account information.');
$sResult = $this->dropboxHelper->getCurrentAccount();
self::assertNotNull($sResult, 'Cannot get account information.');

// $sResult should be a json string, let's assert it below

$this->assertInternalType('string', $sResult);
$aResult = json_decode($sResult, true);
$this->assertInternalType('array', $aResult);

// You shall be informed about the account you are playing with. Maybe only when --verbose or --debug ?
echo $sResult;
}

public function testWriteReadDeleteFile()
Expand Down Expand Up @@ -79,10 +84,10 @@ public function testGetCursor()
return;
}

$oFolder = $this->dropboxHelper->loadFolderPath($this->sFolderPath);
$sCursor = $oFolder->getCursor();
$sCursor = $this->getCursorFromFolderPath($this->sFolderPath);

self::assertNotEmpty($sCursor, 'Failed to get cursor on a loaded folder');
$this->assertInternalType('string', $sCursor);
}

/**
Expand Down Expand Up @@ -186,16 +191,35 @@ public function testListFolderFromCursor()
return;
}

if (empty($this->sCursor)) {
trigger_error('WARNING: Cannot run ' . __FUNCTION__ . ', Dropbox folder cursor is empty.', E_USER_WARNING);
return;
$sCursor = $this->getCursorFromFolderPath($this->sFolderPath);
$oFolder = $this->dropboxHelper->loadFolderCursor($sCursor);

self::assertNotNull($oFolder, sprintf("Cannot load a folder from cursor: `%s`", $sCursor));

$oFolder = $this->dropboxHelper->loadFolderCursor($sCursor);

# Test Folder::next after write
$sTestFilePath = $this->sFolderPath . '/DropboxHelper-test-file-' . uniqid() . '.txt';
$sContent = "PHP Unit Test of DropboxHelper:\n" . (new \DateTime())->format(DATE_ATOM);
$bResult = $this->dropboxHelper->write($sTestFilePath, $sContent);

$oFolder = $this->dropboxHelper->loadFolderCursor($sCursor);
$this->assertInternalType('array', $oFolder->next());

# Race condition: there may be other items to test
while (($aFolder = $oFolder->next())) {
$this->assertInternalType('array', $aFolder);
}

$oFolder = $this->dropboxHelper->loadFolderCursor($this->sCursor);
# Test Folder::next after delete
$bResult = $this->dropboxHelper->delete($sTestFilePath);

self::assertNotNull($oFolder, "Cannot load a folder from cursor: {$this->sCursor}");
$oFolder = $this->dropboxHelper->loadFolderCursor($sCursor);
$this->assertInternalType('array', $oFolder->next());

# Race condition: there may be other items to test
while (($aFolder = $oFolder->next())) {
$this->assertInternalType('array', $aFolder);
}
}

Expand All @@ -207,4 +231,10 @@ public function testFolder()
'Folder is not an instance of Folder()'
);
}
}

private function getCursorFromFolderPath($sFolderPath)
{
$oFolder = $this->dropboxHelper->loadFolderPath($sFolderPath);
return $oFolder->getCursor();
}
}