Skip to content

Sync shapes when dropping elements from table #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bisaloo wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

Sync shapes when dropping elements from table #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions R/methods.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ f <- \(.) setReplaceMethod(.,
y <- attr(x, paste0(., "s"))
y[[i]] <- value
attr(x, paste0(., "s")) <- y
if (. == "table")
x <- .sync_shapes_on_drop(x)
return(x)
})
for (. in one) eval(f(.), parent.env(environment()))
Expand Down
14 changes: 14 additions & 0 deletions R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,17 @@
tables(x) <- ts
return(x)
}

.sync_shapes_on_drop <- \(x) {
if (!length(shapes(x))) return(x)
all_nms <- instances(table(x))
for (i in seq_along(shapes(x))) {
s <- shapes(x)[[i]]
# check which cells still exist
# FIXME: I kind of doubt this always has this name. Do we have an accessor for this???
keep <- s[["__index_level_0__"]] %in% all_nms
Copy link
Copy Markdown
Owner

@HelenaLC HelenaLC May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal either, but I know it is sometimes i) missing, or ii) defined by instance_key of the table - maybe we can check for instance_key, and otherwise something like setdiff(names(s), c("radius", "geometry")? At least a little more robust, until we learn better...

s <- s[keep, , drop = FALSE]
shapes(x)[[i]] <- s
}
return(x)
}
Loading