test(docker-stack): bring up qdrant only to avoid embedding HF bake (TD-628)#177
Merged
Merged
Conversation
…TD-628) Scope every `docker compose up` in test_docker_stack.py to the `qdrant` service so CI never triggers an embedding image build (which hits HuggingFace and fails under rate-limiting). Update wait_for_services_healthy to expect >= 1 healthy service (qdrant-only) and remove stale "BOTH services / embedding model load" references throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Integration Tests" CI job intermittently failed because
tests/integration/test_docker_stack.pybrought up the entire Docker Compose stack (docker compose up -d --waitwith no service filter). That includes theembeddingservice, which bakes HuggingFace models at image-build time — and on a clean CI checkout the build hits HuggingFace's rate limiter (429 Too Many Requests), socompose upexits 1 and the tests error.None of the tests in this file need the embedding service: they only probe Qdrant (port 26350,
/healthz,/). Theqdrantcompose service has a pinnedimage:and nodepends_on, so it starts standalone with no HuggingFace traffic.Change
Scope every
docker compose upintest_docker_stack.pyto theqdrantservice only, and adjustwait_for_services_healthyto expect Qdrant alone (it previously waited for both Qdrant and embedding to report healthy). No other files change.This removes the embedding image build — and therefore HuggingFace — from this job's hot path, eliminating the rate-limit flake. It is also more accurate to what these tests verify (Story 1.1 Qdrant storage/port/health).
Verification
The
qdrant-onlybring-up path is exercised by this CI run itself (a clean checkout with no pre-existing stack). Locally,test_default_port_26350andtest_qdrant_service_accessiblepass.Addresses the recurring Integration Tests flake (also intermittently red on
main). The separate Ubuntuinstall.shHF-429 case is tracked independently and not in scope here.