i18n: localize sidebar panel labels, status messages, and focus indicators by gordonlu · Pull Request #2921 · Hmbown/CodeWhale

gordonlu · 2026-06-09T02:33:15Z

Summary

Localizes 17 Sidebar* MessageIds across the sidebar panels, status bar focus indicators, and toggle messages.

MessageIds added

Surface	MessageIds
Section titles	`SidebarWork`, `SidebarTasks`, `SidebarSession`
Panel labels	`SidebarLiveTools`, `SidebarRecentTools`, `SidebarBackgroundCommands`, `SidebarStrategyMetadata`
Empty states	`SidebarNoActiveWork`, `SidebarNoLiveTools`, `SidebarNoAgents`
Status indicator	`SidebarWorkStateUpdating`
Focus/hidden status	`SidebarFocusWork`, `SidebarFocusTasks`, `SidebarFocusAgents`, `SidebarFocusContext`, `SidebarFocusAuto`, `SidebarHidden`

Files changed

localization.rs: Enum entries + ALL_MESSAGE_IDS + translations for 7 locales
sidebar.rs: All panel labels, empty states, work state updating replaced with tr() calls; Locale parameter threaded through helper functions
ui.rs: Focus status messages via keyboard shortcuts and toggle functions
hotbar/actions.rs: Sidebar toggle status messages
.gitignore: Exclude .claude/settings.json

Not localized (kept English)

Agents section title — product term decision
turn prefix — treated as object ID (like commit abc123)
Agent status values (running, done, etc.) — technical enum values
Config keys (model, provider) — technical identifiers

Testing

create_test_app() pins Locale::En for deterministic tests
All 4338 unit tests pass (only pre-existing macOS flake legacy_sse_closed_stream_reconnects_and_retries_tool_call fails)
cargo fmt --check clean

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

gemini-code-assist

Code Review

This pull request localizes various TUI sidebar strings and status messages across multiple languages. The review feedback highlights several remaining hardcoded English strings (such as 'Agents', 'turn', 'completed', and 'running') that should be localized. Additionally, the reviewer suggests pinning the locale to English in the test setup to ensure deterministic tests and simplify the assertions, rather than asserting on multiple translated variations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-09T02:34:53Z

-    let full_texts = subagent_panel_hover_texts(&summary, &rows, usable_rows.max(1));
+    let full_texts = subagent_panel_hover_texts(&summary, &rows, usable_rows.max(1), app.ui_locale);

    render_sidebar_section(f, area, "Agents", lines, full_texts, app);


The panel title "Agents" is still hardcoded in English here. To ensure complete localization of the sidebar, this should be translated.

Consider adding MessageId::SidebarAgents to crates/tui/src/localization.rs and using it here.

Suggested change

render_sidebar_section(f, area, "Agents", lines, full_texts, app);

render_sidebar_section(f, area, tr(app.ui_locale, MessageId::SidebarAgents), lines, full_texts, app);

Good catch, but this is intentional — Agents is a product term (like SubAgentType kind column values). Per earlier review guidance, product terms that appear consistently across the UI (Agent, SubAgent, AgentTask) are kept in English. Users of this developer tool recognize "Agents" more readily than localized alternatives in this context.

gemini-code-assist · 2026-06-09T02:34:53Z

        let label = if running == 0 {
-            format!("Background commands: {done} completed")
+            format!("{bg_label}: {done} completed")
        } else if done == 0 {
-            format!("Background commands: {running} running")
+            format!("{bg_label}: {running} running")
        } else {
-            format!("Background commands: {running} running, {done} completed")
+            format!("{bg_label}: {running} running, {done} completed")
        };


The status words "completed" and "running" are hardcoded in English, and the sentence structure {bg_label}: {running} running, {done} completed is also hardcoded.

This violates the localization goal of this PR and will result in grammatically incorrect or partially untranslated strings in other languages (e.g., Japanese or Chinese).

To properly localize this, the entire status messages should be defined as parameterized MessageIds (or the status words themselves should be translated) in crates/tui/src/localization.rs.

These status words (running, completed) are technical status enum values consistent with the AgentStatus display pattern used elsewhere (see SubAgents PR #2899 where status values are kept English). They are the same class as done, failed, canceled — not free-form UI copy. Creating parameterized MessageIds for every {status} × {count} combination would be excessive for what is effectively debug-level status information.

gemini-code-assist · 2026-06-09T02:34:53Z

        lines.push(Line::from(Span::styled(
            truncate_line_to_width(
-                &format!("turn {turn_prefix} ({status})",),
+                &format!("turn {turn_prefix} ({status})"),


The word "turn" is hardcoded in English here. To ensure complete localization of the sidebar, this should be defined as a localized message in crates/tui/src/localization.rs.

This is intentional — turn is treated as an object ID prefix (like commit abc123 or PR #456), not UI copy. The value itself (e.g. "turn_abc123") is a technical identifier. Translating it would read as unnatural as translating "commit" in a git hash display.

gemini-code-assist · 2026-06-09T02:34:53Z

+            text.iter()
+                .any(|line| line == "实时工具" || line == "Live tools"),


Instead of adding language-specific checks (like "实时工具") to the test assertions to prevent failures on machines with different system locales, the tests should be made deterministic by pinning the locale in the test setup.

Please update create_test_app() (around line 2437) to explicitly set app.ui_locale = Locale::En; before returning. This ensures the tests are environment-independent and allows you to simplify the assertions back to English-only.

Suggested change

text.iter()

.any(|line| line == "实时工具" || line == "Live tools"),

text.iter()

.any(|line| line == "Live tools"),

Fixed in amended commit — create_test_app() now pins app.ui_locale = Locale::En; and assertions simplified back to English-only.

gemini-code-assist · 2026-06-09T02:34:53Z

+            text.iter()
+                .any(|line| line == "最近工具" || line == "Recent tools"),


Following the suggestion to pin app.ui_locale = Locale::En; in create_test_app(), this assertion can be simplified to only check for "Recent tools".

Suggested change

text.iter()

.any(|line| line == "最近工具" || line == "Recent tools"),

text.iter()

.any(|line| line == "Recent tools"),

Same as above — locale pinned in create_test_app(), assertions back to English-only.

gemini-code-assist · 2026-06-09T02:34:53Z

+            !text
+                .iter()
+                .any(|line| line.contains("后台命令") || line.contains("Background commands")),


Following the suggestion to pin app.ui_locale = Locale::En; in create_test_app(), this assertion can be simplified to only check for "Background commands".

Suggested change

!text

.iter()

.any(|line| line.contains("后台命令") || line.contains("Background commands")),

!text

.iter()

.any(|line| line.contains("Background commands")),

Same as above — locale pinned in create_test_app(), assertions back to English-only.

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

… indicators Adds 17 Sidebar* MessageIds across 7 locales (En, Vi, ZhHant, Ja, ZhHans, PtBr, Es419) covering: - Section titles: Work, Tasks, Session - Panel labels: Live tools, Recent tools, Background commands, Strategy metadata - Empty states: No active work, No live tools or background jobs, No agents - Status indicator: Work state updating... - Focus/hidden status: Sidebar focus: work/tasks/agents/context/auto, Sidebar hidden Agents section title and turn prefix kept as English product terms. All locales get explicit translations (no fallback reliance). sidebar.rs create_test_app() pins Locale::En for deterministic tests.

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Hmbown · 2026-06-10T03:11:19Z

Thanks @gordonlu — we merged #2891 and #2896 from your i18n batch tonight, which moved localization.rs on main, so this slice now shows as conflicting. Could you rebase it onto current main when you get a chance?

Since the slices all touch localization.rs, the smoothest path is to rebase and push them one at a time, oldest-first (#2892 → #2901 → #2918 → #2919 → #2921 → #2926 → #2929 → #2932 → #2940) — we'll merge each promptly so the next rebase stays small. Sorry for the churn; the batch is exactly the right shape and we want all of it.

Hmbown · 2026-06-12T19:00:17Z

Closing this smaller i18n PR as superseded by the consolidation lane in #2239. #2239 covers the same surface area at broader Phase 1-4b scope and is the preferred v0.8.59 review target, though it still has its own outstanding review/fix work before merge.

greptile-apps Bot reviewed Jun 9, 2026

View reviewed changes

gemini-code-assist Bot reviewed Jun 9, 2026

View reviewed changes

gordonlu force-pushed the feat/i18n-sidebar branch from 30daa57 to 2d9b7c2 Compare June 9, 2026 02:45

greptile-apps Bot reviewed Jun 9, 2026

View reviewed changes

gordonlu force-pushed the feat/i18n-sidebar branch from 2d9b7c2 to 28a1041 Compare June 9, 2026 02:49

greptile-apps Bot reviewed Jun 9, 2026

View reviewed changes

This was referenced Jun 10, 2026

feat(i18n): localize sandbox elevation dialog across 7 locales #2892

Merged

feat(i18n): localize ToolFamily labels (10 MessageIds) #2901

Merged

feat(i18n): localize ConfigSection and ConfigScope labels (11 MessageIds) #2918

Closed

Hmbown added the v0.8.59 Targeting v0.8.59 label Jun 11, 2026

Hmbown added this to the v0.8.59 milestone Jun 11, 2026

Hmbown added localization Localization, i18n, and non-English language support ux User experience, interaction, or presentation polish labels Jun 11, 2026

This was referenced Jun 11, 2026

v0.8.59: Review and integrate remaining consistent-contributor PRs through a safe release lane #3100

Closed

v0.8.59 execution roadmap: promoted provider, sub-agent, workflow, docs, and localization work #3098

Closed

Hmbown closed this Jun 12, 2026

	render_sidebar_section(f, area, "Agents", lines, full_texts, app);
	render_sidebar_section(f, area, tr(app.ui_locale, MessageId::SidebarAgents), lines, full_texts, app);

		text.iter()
		.any(\|line\| line == "实时工具" \|\| line == "Live tools"),

		text.iter()
		.any(\|line\| line == "最近工具" \|\| line == "Recent tools"),

Conversation

gordonlu commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

MessageIds added

Files changed

Not localized (kept English)

Testing

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gordonlu Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gordonlu Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gordonlu Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gordonlu Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gordonlu Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gordonlu Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Hmbown commented Jun 10, 2026

Uh oh!

Hmbown commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gordonlu commented Jun 9, 2026 •

edited

Loading